721156 - aError.stack is undefined in the Error Console when exception is thrown in Scratchpad

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:

In the browser context, run the following code:

> var eTLDService = Cc["@mozilla.org/network/effective-tld-service;1"].getService(Ci.nsIEffectiveTLDService);
> let baseDomain = eTLDService.getBaseDomain("www.msu.edu");

Actual results:
In the error console...
Timestamp: 1/25/2012 11:38:44 AM
Error: aError.stack is undefined
Source File: chrome://browser/content/scratchpad.js
Line: 470

Expected results:
An error within the Scratchpad stating that getBaseDomain expected a URI, not a string.

Comment 1

[Heather Arthur [:harth]]

Attachment: Print file and line number if Error.stack isn't defined.

I run into this often, this patch fixes it.

Sometimes Error.stack is undefined and we should show Error.fileName and Error.lineNumber in those cases.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

\o/

Did you forget to assign the review to somebody?

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 608682 [details] [diff] [review]
Print file and line number if Error.stack isn't defined.

My bad, meant to flag robcee.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 608682 [details] [diff] [review]
Print file and line number if Error.stack isn't defined.

yup yup.

Comment 5

[Heather Arthur [:harth]]

http://hg.mozilla.org/integration/fx-team/rev/5e087503286f

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5e087503286f