72122 - Need to implement AdjustSelection on the outliner selection

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Scott MacGregor]

If you have one or more selected items in the outliner widget and you insert one
or more rows above a selected item, the selection gets off. 

i.e. if row 0 is selected, I insert a new row before row 0, the new row appears
to be selected.

Comment 1

[John Morrison]

*** Bug 72121 has been marked as a duplicate of this bug. ***

Comment 2

[John Morrison]

*** Bug 72123 has been marked as a duplicate of this bug. ***

Comment 3

[David Hyatt]

Seth has volunteered for this.  Thanks!

--> sspitzer

Comment 4

[(not reading, please use [e-mail] instead)]

accepting.

Comment 5

[(not reading, please use [e-mail] instead)]

potential fix in hand.  (works so far, but I need to spend some time reviewing
and testing all the edge cases).

here comes the patch, and I'll add some comments to the code tomorrow.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: the fix, not ready for review yet, but here's a preview

Comment 7

[(not reading, please use [e-mail] instead)]

the fix also includes some warnings fixes.

Comment 8

[(not reading, please use [e-mail] instead)]

insertion seems to be working, but deleting mail crashes

I also need to investigate what I should do about mCurrentIndex and
mShiftSelectPivot.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: new patch, fixes the crash on delete problem.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: correct patch, fix some of the delete edge cases.

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: again, this time without the added { } where not needed.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: patch, please review

Comment 13

[(not reading, please use [e-mail] instead)]

updating summary

Comment 14

[(not reading, please use [e-mail] instead)]

setting as p1.

Comment 15

[David Hyatt]

You shouldn't need to invalidate either range, since rowCountCHanged already
does the invalidation of the correct area for you.

Other than that, sr=hyatt

Comment 16

[(not reading, please use [e-mail] instead)]

cool, thanks dave. 

I'll make that change, test it out, and then land.

Comment 17

[(not reading, please use [e-mail] instead)]

fixed.