Last Comment Bug 721248 - make nsICycleCollectorListener builtinclass
: make nsICycleCollectorListener builtinclass
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Andrew McCreight [:mccr8]
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-25 15:52 PST by Andrew McCreight [:mccr8]
Modified: 2012-02-01 06:01 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
simple patch, untested (1.31 KB, patch)
2012-01-27 14:21 PST, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-01-25 15:52:18 PST
Running JS during a CC is a bad idea, and Luke found that with his JS-singlethreading patch, doing so causes some kind of infinite loop.  So we should just ban listeners implemented in JS.
Comment 1 Andrew McCreight [:mccr8] 2012-01-27 14:21:09 PST
Created attachment 592271 [details] [diff] [review]
simple patch, untested
Comment 2 Andrew McCreight [:mccr8] 2012-01-30 16:29:10 PST
Try run looked good.
Comment 3 Andrew McCreight [:mccr8] 2012-01-30 16:30:10 PST
Comment on attachment 592271 [details] [diff] [review]
simple patch, untested

Not a huge priority, but it would be nice to fix this.
Comment 4 Olli Pettay [:smaug] 2012-01-31 02:00:45 PST
Comment on attachment 592271 [details] [diff] [review]
simple patch, untested

Just to be safe, could you update the uuid.
Comment 5 Andrew McCreight [:mccr8] 2012-01-31 05:58:39 PST
Ah, right, I meant to ask about that.  I'll do that, thanks.
Comment 6 Andrew McCreight [:mccr8] 2012-01-31 13:49:02 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/a949ded5a23b
Comment 7 Andrew McCreight [:mccr8] 2012-02-01 06:01:16 PST
https://hg.mozilla.org/mozilla-central/rev/a949ded5a23b

Note You need to log in before you can comment on or make changes to this bug.