Last Comment Bug 721313 - Don't run normal end-of-parse code when parsing full doc from a string
: Don't run normal end-of-parse code when parsing full doc from a string
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Henri Sivonen (:hsivonen)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 650784
  Show dependency treegraph
 
Reported: 2012-01-26 00:37 PST by Henri Sivonen (:hsivonen)
Modified: 2012-01-26 16:06 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Return earlier from DidBuildModel when working for an nsHtml5StringParser (1.87 KB, patch)
2012-01-26 00:51 PST, Henri Sivonen (:hsivonen)
bugs: review+
Details | Diff | Splinter Review

Description Henri Sivonen (:hsivonen) 2012-01-26 00:37:43 PST
When parsing a full doc from a string, nsHtml5TreeOpExecutor unblocks onload an extra time and causes an assertion. Layout start and scroll to ref code unnecessary, too.
Comment 1 Henri Sivonen (:hsivonen) 2012-01-26 00:51:58 PST
Created attachment 591715 [details] [diff] [review]
Return earlier from DidBuildModel when working for an nsHtml5StringParser

We didn't have enough DOMParser reftest/crashtest coverage to catch the assertion earlier.
Comment 2 Henri Sivonen (:hsivonen) 2012-01-26 06:01:38 PST
Thanks for the r+.

https://hg.mozilla.org/integration/mozilla-inbound/rev/39b235bc0ac4
Comment 3 Marco Bonardo [::mak] 2012-01-26 16:06:38 PST
https://hg.mozilla.org/mozilla-central/rev/39b235bc0ac4

Note You need to log in before you can comment on or make changes to this bug.