721350 - Style Editor auto-scroll to the selected style sheet is annoying

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Cedric Vivier [:cedricv]]

The Style Editor should not scroll the list when the style sheet is selected because of a direct user click.

Comment 1

[Cedric Vivier [:cedricv]]

Attachment: patch v1

It shouldn't be too hard to review.

Comment 2

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/d5ceec63ef0a

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d5ceec63ef0a

Comment 4

[Paul Rouget [:paul]]

Comment on attachment 591758 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): Not a regression, new feature.
User impact if declined: Bad user experience.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): very very low. One JS line removed.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 591758 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.

Comment 6

[Paul Rouget [:paul]]

Attachment: Patch v1 - rebased for Aurora

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5bc8243d71ec

Comment 8

[Simona Badau, Desktop QA]

Verified using Firefox 11 beta 3 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6.

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0

The Style Editor does not scroll the list when the style sheet is selected by direct user click.