721422 - [Page Thumbnails] Re-enable tests and make them work with URI_DANGEROUS_TO_LOAD

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We need to use URI_DANGEROUS_TO_LOAD for the moz-page-thumb:// protocol because of bug 721398.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

I consolidated the two tests to a single test. We can just test the whole workflow instead of testing the cache separately.

We now use the hidden appShell to create and contain the canvas and img used to check the thumbnail's contents because that's privileged to load these since the protocol has the URI_DANGEROUS_TO_LOAD flag.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Unfortunately the hiddenDOMWindow is XULWindow only on Mac. Linux and Windows return a normal unprivileged DOMWindow. I borrowed the new solution from the addon-sdk's hidden-frame.js which just creates a hidden XUL frame if needed.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 591998 [details] [diff] [review]
patch v2

Review of attachment 591998 [details] [diff] [review]:
-----------------------------------------------------------------

argh, i forgot about the hidden window nightmare. there's a bug somewhere for having the platform allow proper hidden windows instead of these hackarounds...

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/9921aa6919e5

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> argh, i forgot about the hidden window nightmare. there's a bug somewhere
> for having the platform allow proper hidden windows instead of these
> hackarounds...

Yeah, I know what bug you mean but couldn't find it. It was something about being able to create only a docShell without the browser/frame containing it.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9921aa6919e5