Closed Bug 721459 Opened 8 years ago Closed 8 years ago

Enable WebSMS by default in B2G builds

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: [has patch])

Attachments

(1 file)

Attached patch patchSplinter Review
+++ This bug was initially created as a clone of Bug #720614 +++

WebSMS was disabled by default in bug 720614.  This patch should re-enable it for B2G.  Untested, because I haven't bothered to set up a B2G build environment.
Attachment #591868 - Flags: review?(mounir)
Summary: SMS android permissions being requested on trunk builds → Enable WebSMS by default in B2G builds
Comment on attachment 591868 [details] [diff] [review]
patch

I've no b2g environment either and I'm not a build system peer.
Kyle, would that enable WebSMS for B2G unless --disable-websms-backend is passed to the configure script?
Attachment #591868 - Flags: review?(mounir) → review?(khuey)
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #1)
> Comment on attachment 591868 [details] [diff] [review]
> patch
> 
> I've no b2g environment either and I'm not a build system peer.
> Kyle, would that enable WebSMS for B2G unless --disable-websms-backend is
> passed to the configure script?

Yes, that's what it would do.
Comment on attachment 591868 [details] [diff] [review]
patch

Back to Mounir to determine if this is what b2g wants.
Attachment #591868 - Flags: review?(khuey) → review?(mounir)
Comment on attachment 591868 [details] [diff] [review]
patch

I guess that's is r=mounir,khuey
Attachment #591868 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/cae76db91b49
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.