Closed
Bug 721459
Opened 13 years ago
Closed 13 years ago
Enable WebSMS by default in B2G builds
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: [has patch])
Attachments
(1 file)
642 bytes,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #720614 +++
WebSMS was disabled by default in bug 720614. This patch should re-enable it for B2G. Untested, because I haven't bothered to set up a B2G build environment.
Attachment #591868 -
Flags: review?(mounir)
Assignee | ||
Updated•13 years ago
|
Summary: SMS android permissions being requested on trunk builds → Enable WebSMS by default in B2G builds
Comment 1•13 years ago
|
||
Comment on attachment 591868 [details] [diff] [review]
patch
I've no b2g environment either and I'm not a build system peer.
Kyle, would that enable WebSMS for B2G unless --disable-websms-backend is passed to the configure script?
Attachment #591868 -
Flags: review?(mounir) → review?(khuey)
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #1)
> Comment on attachment 591868 [details] [diff] [review]
> patch
>
> I've no b2g environment either and I'm not a build system peer.
> Kyle, would that enable WebSMS for B2G unless --disable-websms-backend is
> passed to the configure script?
Yes, that's what it would do.
Comment on attachment 591868 [details] [diff] [review]
patch
Back to Mounir to determine if this is what b2g wants.
Attachment #591868 -
Flags: review?(khuey) → review?(mounir)
Comment 4•13 years ago
|
||
Comment on attachment 591868 [details] [diff] [review]
patch
I guess that's is r=mounir,khuey
Attachment #591868 -
Flags: review?(mounir) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•