The default bug view has changed. See this FAQ.

Race condition in about:home for tabs from last time

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec+)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
About:home reads the previous session JSON from sessionstore.js, but sessionstore.js may contain the current session if about:home reads it too late. This isn't much of a problem right now since we always show about:home immediately (meaning sessionstore.js is read before anything is written to it), but this will change when bug 719195 is fixed.
(Assignee)

Comment 1

5 years ago
Created attachment 592000 [details] [diff] [review]
patch
Attachment #592000 - Flags: review?(mark.finkle)
Comment on attachment 592000 [details] [diff] [review]
patch

This looks OK, but I wanted to pitch another thought too: Could we check to see if sessionstore.bak exists and use it. If it doesn't, we could use sessionstore.js ?

The only reason I might like that better is we would be using real file existence as a check, not gecko being ready flag - a flag which does not exactly match up on the session store state.

Thoughts?
Priority: -- → P3
tracking-fennec: --- → +
(Assignee)

Comment 3

5 years ago
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 592000 [details] [diff] [review]
> patch
> 
> This looks OK, but I wanted to pitch another thought too: Could we check to
> see if sessionstore.bak exists and use it. If it doesn't, we could use
> sessionstore.js ?
> 
> The only reason I might like that better is we would be using real file
> existence as a check, not gecko being ready flag - a flag which does not
> exactly match up on the session store state.
> 
> Thoughts?

I originally wanted to do this too, but unfortunately, I don't think that will work. It's possible for sessionstore.bak to have stale data from 2 sessions ago. Consider this sequence:

- have tab google.com open; google.com JSON written to sessionstore.js
- quit
- reopen fennec; google.com JSON moved to sessionstore.bak at session store init
- visit tab cnn.com; cnn.com JSON written to sessionstore.js
- browser crashes
- sessionstore.bak contains google.com JSON rather than cnn.com JSON
tracking-fennec: + → ---
Priority: P3 → --
(Assignee)

Comment 4

5 years ago
Oops - comment collision accidentally killed your flags.
tracking-fennec: --- → ?
Priority: -- → P3
tracking-fennec: ? → +
Comment on attachment 592000 [details] [diff] [review]
patch

OK, lets see where this gets us
Attachment #592000 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 6

5 years ago
Landed on inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/04e40f6991f6
https://hg.mozilla.org/mozilla-central/rev/04e40f6991f6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Brian, please request approval for aurora
(Assignee)

Updated

5 years ago
Attachment #592000 - Flags: approval-mozilla-aurora?

Comment 9

5 years ago
Comment on attachment 592000 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Beta 11.
Attachment #592000 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/cac5504d4637
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.