Last Comment Bug 721579 - Remove rt->gcTriggerBytes and rt->gcLastBytes
: Remove rt->gcTriggerBytes and rt->gcLastBytes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: [PTO to Dec5] Bill McCloskey (:billm)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: IncrementalGC
  Show dependency treegraph
 
Reported: 2012-01-26 16:28 PST by [PTO to Dec5] Bill McCloskey (:billm)
Modified: 2012-02-13 09:07 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.24 KB, patch)
2012-01-26 16:28 PST, [PTO to Dec5] Bill McCloskey (:billm)
igor: review+
Details | Diff | Splinter Review

Description [PTO to Dec5] Bill McCloskey (:billm) 2012-01-26 16:28:50 PST
Created attachment 591991 [details] [diff] [review]
patch

These fields are now used in only one place: a weird case in TriggerCompartmentGC that I've never seen get used. I added the code a long time ago when I was worried that we might get into a situation where full GCs were never happening. I don't think we have to worry about that, though :-(.
Comment 1 Igor Bukanov 2012-01-27 05:34:33 PST
Comment on attachment 591991 [details] [diff] [review]
patch

Review of attachment 591991 [details] [diff] [review]:
-----------------------------------------------------------------

Reducing unnecessary complexity of our GC heuristics is really nice!
Comment 2 [PTO to Dec5] Bill McCloskey (:billm) 2012-02-10 18:35:12 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ed8ccf96402
Comment 3 Phil Ringnalda (:philor) 2012-02-10 19:50:52 PST
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/71f5bf4df2f6 - one of the six in that push was crashing in js::gc::Mark<JSString>
Comment 4 [PTO to Dec5] Bill McCloskey (:billm) 2012-02-12 14:38:46 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/70dd3b785599
Comment 5 Marco Bonardo [::mak] 2012-02-13 09:07:19 PST
https://hg.mozilla.org/mozilla-central/rev/70dd3b785599

Note You need to log in before you can comment on or make changes to this bug.