Remove rt->gcTriggerBytes and rt->gcLastBytes

RESOLVED FIXED in mozilla13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 591991 [details] [diff] [review]
patch

These fields are now used in only one place: a weird case in TriggerCompartmentGC that I've never seen get used. I added the code a long time ago when I was worried that we might get into a situation where full GCs were never happening. I don't think we have to worry about that, though :-(.
Attachment #591991 - Flags: review?(igor)
(Assignee)

Updated

6 years ago
Blocks: 641025

Comment 1

6 years ago
Comment on attachment 591991 [details] [diff] [review]
patch

Review of attachment 591991 [details] [diff] [review]:
-----------------------------------------------------------------

Reducing unnecessary complexity of our GC heuristics is really nice!
Attachment #591991 - Flags: review?(igor) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ed8ccf96402
Target Milestone: --- → mozilla13
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/71f5bf4df2f6 - one of the six in that push was crashing in js::gc::Mark<JSString>
Target Milestone: mozilla13 → ---
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/70dd3b785599
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/70dd3b785599
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.