721583 - Make lightweight themes / Personas work in the Download Manager window

Status: RESOLVED FIXED

(SeaMonkey :: Themes, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: Comment 3]

No idea how I missed it, but the Download Manager is unaffected by lightweight themes (Personas) even though it has (unlike FF) some themeable space at the top (including the search box) and a status bar.

The search box gets lwtheme styling (opacity 0.8) from communicator.css it seems, so AFAICS we need no extra CSS here, unless Stefan objects for Mac.

Comment 1

[Stefan [:stefanh]]

Comment on attachment 591999 [details] [diff] [review]
patch [Checkin: Comment 3]

> The search box gets lwtheme styling (opacity 0.8) from communicator.css
0.9 in the Mac version ;-)


The #clearlistButton needs some lwtheme love - at least for mac. I dunno how it looks in win/nix, but I assume it looks OK.  On Mac, it's kind of hard to read the label in some themes, since the text color/shadow stays the same. To overcome this, I think we need to let the theme dictate the color/shadow (the button itself is just a semi-transparent grey box, so it's OK).

So, ui-r+ if you add the following to suite/themes/classic/mac/communicator/downloads/downloadmanager.css (just after the #clearListButton rules at line 46-52):

#clearListButton:-moz-lwtheme:not([disabled="true"]) {
  color: inherit;
  text-shadow: inherit;
}

Comment 2

[Stefan [:stefanh]]

(I might re-visit and move the style rules, since I'm planning to do something about the Go/Search buttons in navigator)

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 591999 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/db9e96b875aa