721657 - Write out list of contributors to install.rdf as specified in package.json

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The package.json file doesn't support a list of contributors, which get added to the install.rdf file when building the XPI.

This is a very important thing because with our community will be engaged to help with developing and testing add-ons.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Might be worth looking at other fields from install.rdf that would be good to support in package.json.

Comment 2

[David Burns :automatedtester]

would it be worth doing something like npm does? http://npmjs.org/doc/json.html

Comment 3

[Alexandre Poirot [:ochameau]]

Henrik, Actually, I looked at packaging.py, and we already supports `contributors` attribute in package.json:
https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/packaging.py#L18
But we aren't using it anywhere? So it is only matters of writting them in install.rdf from `rdf.py` code. (Like addon name, description, author, ...)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, that's what I already tried to implement in a WIP locally on my machine. But there is still the question, if you also want to have support via an AUTHORS file in the root of the repository? See comment 2 regarding the information as what node.js is doing.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For now i will supply a patch for package.json only. Seems to be sufficient for now. Not sure if we really need the AUTHORS file.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/336

Pointer to Github pull-request

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 594562 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/336

Looks good, we may want to fix minidom issues in a followup bug.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a4f58b3255e7026a493a653b15d115664a9e7294
Merge pull request #336 from whimboo/contributors

Bug 721657 - Write out list of contributors to install.rdf as specified in package.json r=@ochameau

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Code has been landed. Closing as fixed.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Contributors are the most valuable source we have. Given that we do not have a way to list them in the install.rdf file is bad. This patch adds the code to use the contributors as listed in the package.json file and writes them into the install.rdf file. Dave, could it be cherry picked for the 1.5 release?

Comment 11

[Dave Townsend [:mossop]]

(In reply to Henrik Skupin (:whimboo) from comment #10)
> Contributors are the most valuable source we have. Given that we do not have
> a way to list them in the install.rdf file is bad. This patch adds the code
> to use the contributors as listed in the package.json file and writes them
> into the install.rdf file. Dave, could it be cherry picked for the 1.5
> release?

We're just two weeks from releasing 1.5 and spinning our first RC today so I think it is a bit late to take this for 1.5 at this point.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Makes sense. Thanks for the feedback Dave.