Closed
Bug 721781
Opened 13 years ago
Closed 10 years ago
Warn about sync XHR with chrome privileges
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.98 KB,
patch
|
smaug
:
review+
hsivonen
:
review+
|
Details | Diff | Splinter Review |
Let's get this into 12, shall we?
Attachment #592154 -
Flags: review?(bugs)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 592154 [details] [diff] [review]
Patch v1
r+ with a condition. This must not land to m-c before all the
cases where FF uses sync XHR in chrome are fixed.
Also, could the warning message emphasize that the change will happen
in the future. I know, there is "will", but
would "in the future" at the end of the sentence be ok?
Attachment #592154 -
Flags: review?(hsivonen)
Attachment #592154 -
Flags: review?(bugs)
Attachment #592154 -
Flags: review+
|
||
Comment 2•13 years ago
|
||
Comment on attachment 592154 [details] [diff] [review]
Patch v1
r=hsivonen provided that this won't be checked in before sync XHR use has been removed from the chrome code that Firefox itself runs.
I'd also add "in a future release" at the end of the warning sentence.
Attachment #592154 -
Flags: review?(hsivonen) → review+
|
||
Comment 3•10 years ago
|
||
We already warns *all* sync XHR, not only chrome privileged one.
|
||
Updated•10 years ago
|
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•