Last Comment Bug 721881 - Port |Bug 666306 - Video content should become large play button ...| to Modern
: Port |Bug 666306 - Video content should become large play button ...| to Modern
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.9
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-27 14:35 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2012-01-29 01:37 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: Comment 3] (4.89 KB, patch)
2012-01-27 14:35 PST, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2012-01-27 14:35:05 PST
Created attachment 592275 [details] [diff] [review]
patch [Checkin: Comment 3]

Bug 666306, which just landed on trunk, added a "click to play" button for HTML5 videos to Toolkit. Modern can reuse the artwork, but needs to have the CSS ported.
Comment 1 Philip Chee 2012-01-28 11:43:13 PST
> +  skin/modern/global/media/clicktoplay-bgtexture.png               (/mozilla/toolkit/themes/winstripe/global/media/clicktoplay-bgtexture.png)
>    skin/modern/global/media/error.png                               (/mozilla/toolkit/themes/winstripe/global/media/error.png)
I think Neil prefers that we copy any images into Modern. In the past we've been caught out when toolkit/firefox changed the name of images or just removed them.
Comment 2 neil@parkwaycc.co.uk 2012-01-28 16:09:06 PST
Comment on attachment 592275 [details] [diff] [review]
patch [Checkin: Comment 3]

>+  background-color: hsla(0,0%,10%,.5);
[hsla? whatever next?]
Comment 3 Jens Hatlak (:InvisibleSmiley) 2012-01-29 01:35:02 PST
Comment on attachment 592275 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/c504e4a24ad9

Note You need to log in before you can comment on or make changes to this bug.