Closed
Bug 721888
Opened 14 years ago
Closed 14 years ago
Fennec native build doesn't flag java warnings as errors
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 fixed, firefox12 fixed)
RESOLVED
FIXED
Firefox 12
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(2 files, 2 obsolete files)
|
1.34 KB,
patch
|
blassey
:
review+
blassey
:
approval-mozilla-aurora+
blassey
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
|
507 bytes,
patch
|
blassey
:
review+
blassey
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Now that the websms thing is disabled we have a window of opportunity to turn on warnings-as-errors for java code to prevent introducing more warnings.
Attachment #592285 -
Flags: review?(mark.finkle)
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #592287 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•14 years ago
|
||
I have a try push running to build on all platforms to make sure it doesn't break anything: https://tbpl.mozilla.org/?tree=Try&rev=2067d01d149a
|
||
Updated•14 years ago
|
Attachment #592285 -
Flags: review?(mark.finkle) → review+
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 592287 [details] [diff] [review]
(2/2) Add -Werror to javac command-line
I'd rather you put -Werror in JAVAC_FLAGS
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #592287 -
Attachment is obsolete: true
Attachment #592287 -
Flags: review?(mark.finkle)
Attachment #592335 -
Flags: review?(blassey.bugs)
|
|
Assignee | |
Comment 5•14 years ago
|
||
cpeterson pointed out a better place to modify JAVAC_FLAGS. sorry for the churn/bugmail.
Attachment #592335 -
Attachment is obsolete: true
Attachment #592335 -
Flags: review?(blassey.bugs)
Attachment #592343 -
Flags: review?(blassey.bugs)
|
|
||
Updated•14 years ago
|
Attachment #592343 -
Flags: review?(blassey.bugs) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2571f70b20c5
https://hg.mozilla.org/integration/mozilla-inbound/rev/024b7dac0eaf
tracking-fennec: --- → ?
status-firefox11:
--- → affected
status-firefox12:
--- → fixed
Target Milestone: --- → Firefox 12
|
||
Comment 7•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2571f70b20c5
https://hg.mozilla.org/mozilla-central/rev/024b7dac0eaf
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•14 years ago
|
||
Kats, please request approval for aurora
|
|
Assignee | |
Comment 9•14 years ago
|
||
Comment on attachment 592285 [details] [diff] [review]
(1/2) Fix last two java warnings
[Approval Request Comment]
Regression caused by (bug #): 603008
User impact if declined: none; compiler warning fix only
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): possible rebase errors on future patches that affect this code.
Attachment #592285 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #592343 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•14 years ago
|
Attachment #592285 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Updated•14 years ago
|
Attachment #592343 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 10•14 years ago
|
||
Comment on attachment 592285 [details] [diff] [review]
(1/2) Fix last two java warnings
[Triage Comment]
approved for beta as well
Attachment #592285 -
Flags: approval-mozilla-beta+
|
|
||
Comment 11•14 years ago
|
||
Comment on attachment 592343 [details] [diff] [review]
(2/2) Add -Werror to JAVAC_FLAGS
[Triage Comment]
now approved for beta
Attachment #592343 -
Flags: approval-mozilla-aurora+ → approval-mozilla-beta+
|
||
Comment 12•14 years ago
|
||
|
||
Updated•12 years ago
|
tracking-fennec: ? → ---
|
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•