Fennec native build doesn't flag java warnings as errors

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 592285 [details] [diff] [review]
(1/2) Fix last two java warnings

Now that the websms thing is disabled we have a window of opportunity to turn on warnings-as-errors for java code to prevent introducing more warnings.
Attachment #592285 - Flags: review?(mark.finkle)
Created attachment 592287 [details] [diff] [review]
(2/2) Add -Werror to javac command-line
Attachment #592287 - Flags: review?(mark.finkle)
I have a try push running to build on all platforms to make sure it doesn't break anything: https://tbpl.mozilla.org/?tree=Try&rev=2067d01d149a
Attachment #592285 - Flags: review?(mark.finkle) → review+
Comment on attachment 592287 [details] [diff] [review]
(2/2) Add -Werror to javac command-line

I'd rather you put -Werror in JAVAC_FLAGS
Created attachment 592335 [details] [diff] [review]
(2/2) Add -Werror to JAVAC_FLAGS
Attachment #592287 - Attachment is obsolete: true
Attachment #592287 - Flags: review?(mark.finkle)
Attachment #592335 - Flags: review?(blassey.bugs)
Created attachment 592343 [details] [diff] [review]
(2/2) Add -Werror to JAVAC_FLAGS

cpeterson pointed out a better place to modify JAVAC_FLAGS. sorry for the churn/bugmail.
Attachment #592335 - Attachment is obsolete: true
Attachment #592335 - Flags: review?(blassey.bugs)
Attachment #592343 - Flags: review?(blassey.bugs)
Attachment #592343 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2571f70b20c5
https://hg.mozilla.org/integration/mozilla-inbound/rev/024b7dac0eaf
tracking-fennec: --- → ?
status-firefox11: --- → affected
status-firefox12: --- → fixed
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/2571f70b20c5
https://hg.mozilla.org/mozilla-central/rev/024b7dac0eaf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Kats, please request approval for aurora
Comment on attachment 592285 [details] [diff] [review]
(1/2) Fix last two java warnings

[Approval Request Comment]
Regression caused by (bug #): 603008
User impact if declined: none; compiler warning fix only
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): possible rebase errors on future patches that affect this code.
Attachment #592285 - Flags: approval-mozilla-aurora?
Attachment #592343 - Flags: approval-mozilla-aurora?
Attachment #592285 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #592343 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 592285 [details] [diff] [review]
(1/2) Fix last two java warnings

[Triage Comment]
approved for beta as well
Attachment #592285 - Flags: approval-mozilla-beta+
Comment on attachment 592343 [details] [diff] [review]
(2/2) Add -Werror to JAVAC_FLAGS

[Triage Comment]
now approved for beta
Attachment #592343 - Flags: approval-mozilla-aurora+ → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/313420d2352b
https://hg.mozilla.org/releases/mozilla-beta/rev/cf28d8de40f7
status-firefox11: affected → fixed
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.