large number of reftest failures, possibly related to incorrect font-size inflation?

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Text
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
Seen on mozilla-inbound:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8900199&tree=Mozilla-Inbound

Total of 123 reftest failures, beginning with

REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-calc/max-width-block-intrinsic-1.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-calc/min-width-block-intrinsic-1.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-calc/text-indent-intrinsic-1.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-calc/vertical-align-1.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-calc/width-block-intrinsic-1.html | image comparison (==)
REFTEST TEST-UNEXPECTED-PASS | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/css-gradients/height-dependence-2.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/text-overflow/marker-basic.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/text-overflow/quirks-decorations.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/text-overflow/quirks-line-height.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/text-overflow/standards-decorations.html | image comparison (==)
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/reftests/text-overflow/standards-line-height.html | image comparison (==)
....

Looking at a sampling of the failures, many of them appear to show incorrect font-size inflation; so I wonder whether this could be a new intermittent failure, perhaps triggered by bug 698652, which was the push immediately preceding this one (but didn't exhibit the failures itself).
The first linked failure layout/reftests/css-calc/max-width-block-intrinsic-1.html doesn't touch <canvas> at all, which is where the substantive changes in bug 698652 were made.  That would suggest the reftest-manifest pref() annotation is buggy.  Sigh.

If this is more than "once in a blue moon" intermittent, then I suggest we back out the test and fix the reftest harness.
(Assignee)

Comment 2

5 years ago
Doesn't the reftest harness use canvas all the time?

Yes, it's entirely possible that the real problem lies with the pref() annotation - that's fairly new (bug 696585) and not yet heavily used, afaik.

I re-triggered the (green) OS X Opt reftest run on changeset c8ea6b7164bc (the bug 698652 push), and got the failures there as well. OTOH, a couple of re-runs on the following changeset, where this first occurred, came up green.
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Doesn't the reftest harness use canvas all the time?
> 

Yes, but it uses canvas as a pixel-buffer target for drawWindow().  The end result is approximately saving a "screenshot" of the top-level XUL <window> to canvas, no repainting (except in extreme edge cases that we shouldn't hit in reftests).

What's your guess at the percent of intermittent failing runs right now?
(Assignee)

Comment 4

5 years ago
Looks like about 30% at the moment - 3 out of 10 runs on the relevant changesets have come up orange.

The failures are only on OS X opt, however; it hasn't happened on any other platform, for some reason.

Just checking - is the font-size inflation pref supposed to be fully "live apply"? If not, then it shouldn't be expected to work with the pref(...) annotation.
(Assignee)

Comment 5

5 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #4)

> The failures are only on OS X opt, however; it hasn't happened on any other
> platform, for some reason.

I take that back - we just got an instance on WinXP opt:

https://tbpl.mozilla.org/php/getParsedLog.php?id=8902773&tree=Mozilla-Inbound
OK.  I'm barely awake, but

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ea6b7164bc

is the patch to back out.  If that eliminates the orange, then the bug is in the new reftest harness support for pref().
(Assignee)

Comment 7

5 years ago
The failures happened several more times in the last few hours, so I backed out this test in

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcaff471b385

Let's confirm whether this resolves the orange, then file a bug on the reftest harness if necessary.
https://tbpl.mozilla.org/php/getParsedLog.php?id=8908961&tree=Mozilla-Inbound (from right before the backout)
https://hg.mozilla.org/mozilla-central/rev/bcaff471b385

I'll leave this open because of comment 7
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla12
Filed bug 722569.  This bug was fixed by backing out the test.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.