remove extra semicolon after NS_DECl_EVENT_HANDLER

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
x86
OpenBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Followup to bug #718132, (and similar to #704729) m-c fails now on OpenBSD/gcc 4.2.1 with a bunch of :
In file included from ../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:45,
                 from ../../dist/include/mozilla/dom/indexedDB/FileInfo.h:46,
                 from ../../dist/include/nsDOMFile.h:56,
                 from /home/landry/src/mozilla-central/layout/forms/../../content/html/content/src/nsHTMLInputElement.h:51,
                 from /home/landry/src/mozilla-central/layout/forms/nsFileControlFrame.cpp:67:
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:158: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:159: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:160: error: extra ';'
In file included from ../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:46,
                 from ../../dist/include/mozilla/dom/indexedDB/FileInfo.h:46,
                 from ../../dist/include/nsDOMFile.h:56,
                 from /home/landry/src/mozilla-central/layout/forms/../../content/html/content/src/nsHTMLInputElement.h:51,
                 from /home/landry/src/mozilla-central/layout/forms/nsFileControlFrame.cpp:67:
../../dist/include/mozilla/dom/indexedDB/IDBRequest.h:161: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBRequest.h:162: error: extra ';'

Patch incoming..
(Assignee)

Updated

6 years ago
Depends on: 718132
Summary: remove extra ; after NS_DECl_EVENT_HANDLER → remove extra semicolon after NS_DECl_EVENT_HANDLER
(Assignee)

Comment 1

6 years ago
Created attachment 592396 [details] [diff] [review]
Remove extra semicolons
Assignee: nobody → landry
Attachment #592396 - Flags: review?(bent.mozilla)
(Assignee)

Comment 2

6 years ago
And it seems it's very similar to bug #720815 which resolution only fixed one of three occurences..
Comment on attachment 592396 [details] [diff] [review]
Remove extra semicolons

r=me if you also fix the others at <http://mxr.mozilla.org/mozilla-central/ident?i=NS_DECL_EVENT_HANDLER>
Attachment #592396 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 592401 [details] [diff] [review]
Remove extra semicolons

Sure, here you are. Wonder why IDBTransaction.h didn't error out first (i can understand for dom/telephony)
Attachment #592396 - Attachment is obsolete: true
Attachment #592401 - Flags: review?(Ms2ger)
Comment on attachment 592401 [details] [diff] [review]
Remove extra semicolons

Thanks. (Don't forget to update your commit message.)
Attachment #592401 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 6

6 years ago
I can't edit the commit message without reposting a new patch & reasking for review, and i didn't hit the other occurences.. so, to whoever commits the diff, please remove the extra error lines and only keep the summary line. (is it the right way to do it ?)
Keywords: checkin-needed
Pushed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a514effc2a

Also, for future reference:

(In reply to Landry Breuil from comment #6)
> I can't edit the commit message without reposting a new patch & reasking for
> review

Don't worry about reasking for review in that case -- if someone grants you r+ with a few changes requested, general practice is to re-post without needing to ask for review on the new patch.  (Just be sure not to obsolete the old patch, so that whoever pushes the patch will see that an earlier version has gotten r+ & can easily compare the two versions)

(No need to do that here, though, as I've already pushed the patch w/ updated commit message)

> please remove the extra error lines and only keep the summary line.
> (is it the right way to do it ?)

Yup -- single-line commit messages are the standard practice for mozilla repositories.
(like "Bug XXX: change foo to bar. r=whoever")
(adding "buildwarning" keyword since this caused build warnings on Linux GCC 4.6)
Blocks: 187528
(er s/keyword/bug-dependency/. Finished with bugspam now, sorry. :))
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d9a514effc2a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.