Sub-tile invalidation isn't working properly on pages with animations

RESOLVED FIXED in Firefox 12

Status

()

Firefox for Android
General
--
major
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: pcwalton, Assigned: cwiiis)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 unaffected, firefox12 fixed, firefox13 fixed)

Details

(Whiteboard: [not-fennec-11])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
I see random tiles flickering in and out of view on pages with animations. Often I see a tile that's completely blank except for the animated bit. It looks like subtile invalidation isn't working.
(Reporter)

Comment 1

6 years ago
It works when remaining still on pages with animations, but when panning around it causes the behavior described above.
I don't think we can uplift tiling to Aurora before this is fixed.
(Assignee)

Updated

6 years ago
Blocks: 717283
(Assignee)

Comment 2

6 years ago
Looking at this, I can reproduce on http://www.kevs3d.co.uk/dev/asteroidsbench/
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
Well, I can't reproduce random tiles flickering, but tiles that have sub-region updates end up with only the updated region and the rest of the tile disappears. If random tiles are disappearing entirely, that may be a different problem, but hopefully we're talking about the same thing.
(Assignee)

Comment 4

6 years ago
Created attachment 592715 [details] [diff] [review]
Fix invalidation of MultiTileLayer during animations

This fixes invalidations during animations. We were using getOrigin/getResolution to compare newly set origins/resolutions with the previously set one, but if two updates happened in quick succession, the layer could be locked for long enough that an update wouldn't happen and so the buffer would be incorrectly invalidated.
Attachment #592715 - Flags: review?(pwalton)
(Reporter)

Comment 5

6 years ago
Comment on attachment 592715 [details] [diff] [review]
Fix invalidation of MultiTileLayer during animations

Review of attachment 592715 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Definitely an improvement. Unfortunately it's hard for me to tell whether this actually fully fixes the problem due to the layout regression (which I tried backing out, but the problem still exists... it'll take more time than I threw at it.)
(Reporter)

Updated

6 years ago
Attachment #592715 - Flags: review?(pwalton) → review+

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8919c54229e1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
patrick, should this be uplifted?
Chris, please request beta approval and make sure this applies in the landing patch queue
Already in aurora (Fx 12).

Not needed in beta as it is a follow-up for bug 717283 which isn't in beta.
tracking-fennec: --- → ?
status-firefox11: --- → unaffected
status-firefox12: --- → fixed
status-firefox13: --- → fixed
Whiteboard: [not-fennec-11]
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.