722068 - Sub-tile invalidation isn't working properly on pages with animations

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Patrick Walton (:pcwalton)]

I see random tiles flickering in and out of view on pages with animations. Often I see a tile that's completely blank except for the animated bit. It looks like subtile invalidation isn't working.

Comment 1

[Patrick Walton (:pcwalton)]

It works when remaining still on pages with animations, but when panning around it causes the behavior described above.
I don't think we can uplift tiling to Aurora before this is fixed.

Comment 2

[Chris Lord [:cwiiis]]

Looking at this, I can reproduce on http://www.kevs3d.co.uk/dev/asteroidsbench/

Comment 3

[Chris Lord [:cwiiis]]

Well, I can't reproduce random tiles flickering, but tiles that have sub-region updates end up with only the updated region and the rest of the tile disappears. If random tiles are disappearing entirely, that may be a different problem, but hopefully we're talking about the same thing.

Comment 4

[Chris Lord [:cwiiis]]

Attachment: Fix invalidation of MultiTileLayer during animations

This fixes invalidations during animations. We were using getOrigin/getResolution to compare newly set origins/resolutions with the previously set one, but if two updates happened in quick succession, the layer could be locked for long enough that an update wouldn't happen and so the buffer would be incorrectly invalidated.

Comment 5

[Patrick Walton (:pcwalton)]

Comment on attachment 592715 [details] [diff] [review]
Fix invalidation of MultiTileLayer during animations

Review of attachment 592715 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Definitely an improvement. Unfortunately it's hard for me to tell whether this actually fully fixes the problem due to the layout regression (which I tried backing out, but the problem still exists... it'll take more time than I threw at it.)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8919c54229e1

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

patrick, should this be uplifted?

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Chris, please request beta approval and make sure this applies in the landing patch queue

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Already in aurora (Fx 12).

Not needed in beta as it is a follow-up for bug 717283 which isn't in beta.