The default bug view has changed. See this FAQ.

Build --with-system-libvpx is broken for libvpx-1.0.0

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ojab, Assigned: ojab)

Tracking

unspecified
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
libvpx-1.0.0 is out (link to the changelog in URL), but firefox's configure fails to find system libvpx:

$ make -f client.mk  
…
checking for libvpx version >= v0.9.7... no
configure: error: --with-system-libvpx requested but it is not v0.9.7 or later

There is no VPX_CODEC_USE_INPUT_PARTITION define in libvpx-1.0.0 source tree.
Yeah, the API isn't quite as compatible as the CHANGELOG would suggest. I'll take care of this.
Assignee: nobody → tterribe
(Assignee)

Comment 2

5 years ago
Created attachment 592612 [details] [diff] [review]
libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define

It seems that VPX_CODEC_USE_INPUT_PARTITION was changed to VPX_CODEC_USE_INPUT_FRAGMENTS in 1.0.0.
Attachment #592612 - Flags: review?(tterribe)
Comment on attachment 592612 [details] [diff] [review]
libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define

I think we actually want to drop support for v0.9.7, because of bug 696390. Just change the check to look for VPX_CODEC_USE_INPUT_FRAGMENTS only. That makes the comment above the check wrong (v1.0.0 does have new symbols we could check for, but they're encoder-only, and we currently don't require encode support). The version in the error message we give when v0.9.7 isn't found will also need to be updated.
Attachment #592612 - Flags: review?(tterribe) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 592622 [details] [diff] [review]
Updated patch, bump requred libvpx version to 1.0.0
Attachment #592612 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #592622 - Flags: review?(tterribe)
Attachment #592622 - Flags: review?(tterribe) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/e73a68477cfd
Assignee: tterribe → ojab
Component: Video/Audio → Build Config
Keywords: checkin-needed
QA Contact: video.audio → build-config
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/e73a68477cfd
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
(In reply to ojab from comment #2)
> Created attachment 592612 [details] [diff] [review]
> libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define
> 
> It seems that VPX_CODEC_USE_INPUT_PARTITION was changed to
> VPX_CODEC_USE_INPUT_FRAGMENTS in 1.0.0.

This makes no sense anymore, we could simple use the pkgconfig file to setup the libs/cflags even check version. This would make it much more robust and simply the code greatly.
(In reply to Jory A. Pratt from comment #7)
> This makes no sense anymore, we could simple use the pkgconfig file to setup
> the libs/cflags even check version. This would make it much more robust and
> simply the code greatly.

We'd probably take a patch to use pkgconfig. Feel free to open a new bug about it.

Updated

5 years ago
Blocks: 741737

Comment 9

5 years ago
Pkgconfig bug/patch filled as bug 741737.
You need to log in before you can comment on or make changes to this bug.