722127 - Build --with-system-libvpx is broken for libvpx-1.0.0

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[ojab]

libvpx-1.0.0 is out (link to the changelog in URL), but firefox's configure fails to find system libvpx:

$ make -f client.mk  
…
checking for libvpx version >= v0.9.7... no
configure: error: --with-system-libvpx requested but it is not v0.9.7 or later

There is no VPX_CODEC_USE_INPUT_PARTITION define in libvpx-1.0.0 source tree.

Comment 1

[Timothy B. Terriberry (:derf)]

Yeah, the API isn't quite as compatible as the CHANGELOG would suggest. I'll take care of this.

Comment 2

[ojab]

Attachment: libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define

It seems that VPX_CODEC_USE_INPUT_PARTITION was changed to VPX_CODEC_USE_INPUT_FRAGMENTS in 1.0.0.

Comment 3

[Timothy B. Terriberry (:derf)]

Comment on attachment 592612 [details] [diff] [review]
libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define

I think we actually want to drop support for v0.9.7, because of bug 696390. Just change the check to look for VPX_CODEC_USE_INPUT_FRAGMENTS only. That makes the comment above the check wrong (v1.0.0 does have new symbols we could check for, but they're encoder-only, and we currently don't require encode support). The version in the error message we give when v0.9.7 isn't found will also need to be updated.

Comment 4

[ojab]

Attachment: Updated patch, bump requred libvpx version to 1.0.0

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e73a68477cfd

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e73a68477cfd

Comment 7

[Jory A. Pratt [:anarchy]]

(In reply to ojab from comment #2)
> Created attachment 592612 [details] [diff] [review]
> libvpx-1.0.0 has VPX_CODEC_USE_INPUT_FRAGMENTS define
> 
> It seems that VPX_CODEC_USE_INPUT_PARTITION was changed to
> VPX_CODEC_USE_INPUT_FRAGMENTS in 1.0.0.

This makes no sense anymore, we could simple use the pkgconfig file to setup the libs/cflags even check version. This would make it much more robust and simply the code greatly.

Comment 8

[Timothy B. Terriberry (:derf)]

(In reply to Jory A. Pratt from comment #7)
> This makes no sense anymore, we could simple use the pkgconfig file to setup
> the libs/cflags even check version. This would make it much more robust and
> simply the code greatly.

We'd probably take a patch to use pkgconfig. Feel free to open a new bug about it.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Pkgconfig bug/patch filled as bug 741737.