Tilt visualization mesh isn't correctly positioned when scrollbars are present or when the document body is smaller than the content window

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

([tilt])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
For example:

Open a webpage with a scrollbar.
Open inspector.
Open tilt.

The intro and outro animations clearly doesn't take the current scrollbar width (if present) into consideration. This makes things ugly.

Also: open a page with a small body in Tilt. For example, tbpl or about:blank. The mesh is centered in a weird way on the Y axis.
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
(Assignee)

Comment 1

5 years ago
Created attachment 592475 [details] [diff] [review]
v1

Does this need a test?
Attachment #592475 - Flags: review?(rcampbell)
(Assignee)

Comment 2

5 years ago
Comment on attachment 592475 [details] [diff] [review]
v1

(In reply to Victor Porof from comment #1)
> Created attachment 592475 [details] [diff] [review]
> v1
> 
> Does this need a test?

Of course it doesn't because it breaks some existing ones :)
Attachment #592475 - Flags: review?(rcampbell)
(Assignee)

Comment 3

5 years ago
Created attachment 592501 [details] [diff] [review]
v2
Attachment #592475 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #592501 - Attachment is patch: true
(Assignee)

Comment 4

5 years ago
Created attachment 592518 [details] [diff] [review]
v3

The solution was much, much easier. No need to calculate scrollbar dimensions.
Attachment #592501 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Comment on attachment 592518 [details] [diff] [review]
v3

This survived try: https://tbpl.mozilla.org/?tree=Try&rev=ce9d3ecd89e5
So much green!
Attachment #592518 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Depends on: 719877
(Assignee)

Updated

5 years ago
Blocks: 715970
Attachment #592518 - Flags: review?(rcampbell) → review+
Whiteboard: [tilt] → [tilt][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/a82b581bd1b0
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a82b581bd1b0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.