722129 - Tilt visualization mesh isn't correctly positioned when scrollbars are present or when the document body is smaller than the content window

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

For example:

Open a webpage with a scrollbar.
Open inspector.
Open tilt.

The intro and outro animations clearly doesn't take the current scrollbar width (if present) into consideration. This makes things ugly.

Also: open a page with a small body in Tilt. For example, tbpl or about:blank. The mesh is centered in a weird way on the Y axis.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Does this need a test?

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 592475 [details] [diff] [review]
v1

(In reply to Victor Porof from comment #1)
> Created attachment 592475 [details] [diff] [review]
> v1
> 
> Does this need a test?

Of course it doesn't because it breaks some existing ones :)

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v3

The solution was much, much easier. No need to calculate scrollbar dimensions.

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 592518 [details] [diff] [review]
v3

This survived try: https://tbpl.mozilla.org/?tree=Try&rev=ce9d3ecd89e5
So much green!

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/a82b581bd1b0

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a82b581bd1b0