722255 - Add-ons Manager: Extension icon is scaled down unnecessarily

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Add-on Manager, defect, P3)

Description

[Wladimir Palant]

Attachment: Screenshot

See screenshot - that's the details view for Adblock Plus. The icon displayed there has size 48x48 (recommended as of Firefox 4). However, the style rules in aboutAddons.css scale it down to 32x32. That seems absolutely unnecessary - the icon is being displayed in an area with size approximately 82x84, that would be even enough to display the 64x64 icon (which is defined but currently not used by the Add-ons Manager in Fennec).

Comment 1

[Wladimir Palant]

Note that the box reserved for the add-on icon has the same size in the add-on list, yet it also shows a tiny version of the icon.

Comment 2

[Aaron Train [:aaronmt]]

:mfinkle's call

Comment 3

[Matt Brubeck (:mbrubeck)]

Currently we lay out all icons at 32*32px.

The simplest fix would be to change this hard-coded size to a different size, and lay out all icons at, say, 48px.  This would mean scaling up the 32px icons currently used for our default search engines and several existing add-ons.  If we do this, we should also create new 48px icons for the four default search engines and for the more popular add-ons we control.

Alternately, we can specify a range of sizes, like "min-width: 32px; max-width: 48px;".  Then icons within that range will render at their natural size, while icons outside the range will be scaled to fit.  Because of the way the positioning code happens to be implemented, this would require a more involved change on the implementation side.

Ian and Patryk, what do you think?

Comment 4

[:Margaret Leibovic]

antlam, do you think we should change the size of the icons in about:addons? Or should we close this as a WONTFIX?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Wladimir Palant from comment #0)
> Created attachment 592646 [details]
> Screenshot
> 
> See screenshot - that's the details view for Adblock Plus. The icon
> displayed there has size 48x48 (recommended as of Firefox 4). However, the
> style rules in aboutAddons.css scale it down to 32x32. That seems absolutely
> unnecessary - the icon is being displayed in an area with size approximately
> 82x84, that would be even enough to display the 64x64 icon (which is defined
> but currently not used by the Add-ons Manager in Fennec).

Fair point, Wladimir. But I think the clearance provided by the space around the icon is actually intended to be give each row more breathing room. Increasing the icon size will decrease that padding and throw the balance off.

I can also see some unforeseen issues in addition to those already outlined by mbrubeck. Since this UI works right now and there isn't any usability issues directly associated with the size specifically, it's hard to justify this change without knowing fully how this affects the bigger picture. 

In short: I am looking at Panel UI improvements/clean up overall as a part of bug 1063058 where I'll also keep this in mind. :)

(In reply to :Margaret Leibovic from comment #4)
> antlam, do you think we should change the size of the icons in about:addons?
> Or should we close this as a WONTFIX?

For those reasons, I'd say this is a WONTFIX for now.

Comment 6

[Wladimir Palant]

Well, the other option would be allowing to specify a proper 32x32 icon. Well, ugly scaled down extension icons it is then I guess...