72226 - [FIX]Disabled items change visual state

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[rods (gone)]

Somebody else broke this (I think joki) but it did so me whereI didn't have some 
code I should have.

Comment 1

[rods (gone)]

This is related to bug 58855 

Patch:
Index: nsListControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsListControlFrame.cpp,v
retrieving revision 1.183
diff -u -r1.183 nsListControlFrame.cpp
--- nsListControlFrame.cpp      2001/03/13 01:47:16     1.183
+++ nsListControlFrame.cpp      2001/03/16 20:42:28
@@ -3389,7 +3389,10 @@
     if (isDroppedDown) {
       PRInt32 oldIndex;
       PRInt32 curIndex = mSelectedIndex;
-      if (NS_SUCCEEDED(GetIndexFromDOMEvent(aMouseEvent, oldIndex, curIndex)))
{
+      PRBool optionIsDisabled = PR_FALSE;
+      nsresult rv = IsTargetOptionDisabled(optionIsDisabled);
+      if (NS_SUCCEEDED(GetIndexFromDOMEvent(aMouseEvent, oldIndex, curIndex)) &
&
+          NS_SUCCEEDED(rv) && !optionIsDisabled) {
         mSelectedIndex    = curIndex;
         mOldSelectedIndex = oldIndex;
         if (kNothingSelected != mSelectedIndex) {

Comment 2

[Christopher Blizzard (:blizzard)]

Rod, is this safe for 0.8.1?

Comment 3

[Marc Attinasi]

Shouldn't

+      PRBool optionIsDisabled = PR_FALSE;
+      nsresult rv = IsTargetOptionDisabled(optionIsDisabled);

be inside of the if statement? Why do you care if the option is disabled if
GetIndexFromDOMEvent falis?

Comment 4

[rods (gone)]

Attachment: duh.. Here's abetter patch (and yes this is very safe)

Comment 5

[rods (gone)]

Attachment: Ignore previous patch, this one has been tested

Comment 6

[Marc Attinasi]

Looks good to me: [s]r=attinasi

Comment 7

[Brendan Eich [:brendan]]

Who should give another r/sr=?  Cc'ing waterson.

/be

Comment 8

[Chris Waterson]

looks good, r=waterson

Comment 9

[rods (gone)]

Fixed on branch, I need to check in on tip

Comment 10

[rods (gone)]

fixed in tip and branch

Comment 11

[Vladimir Ermakov]

rods: Could you please provide some kind of testcase, to help me verify this, 
because its not very clear from description how to reproduce this.

Comment 12

[Vladimir Ermakov]

Verifying by developer's coments.