Closed Bug 722278 Opened 10 years ago Closed 10 years ago

After closing tab on overflowing tab list popup, empty space remains

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox11- affected, firefox12- affected, fennec+)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 - affected
firefox12 - affected
fennec + ---

People

(Reporter: martijn.martijn, Assigned: sriram)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Screenshot of bug
Steps to reproduce:
- Open up 4 tabs, so tab list popup overflows
- Close 2nd and 3rd tab

Expected result:
- 2 tabs remain in the tab list, no empty space at bottom of tab list popup

Actual result:
- 2 tabs remain in the tab list, empty space at bottom of tab list popup remains

Tested on current Native trunk build on the LG Optimus Black, Android 2.2.2, portrait mode.
OS: Windows 7 → Android
Hardware: x86 → ARM
CC'ing :sriram.
Keywords: regression
Assignee: nobody → sriram
tracking-fennec: --- → +
Attached patch PatchSplinter Review
This somehow requires way too many calculations :(
This is found to work the way UX team wants.
Attachment #595156 - Flags: review?(mark.finkle)
Comment on attachment 595156 [details] [diff] [review]
Patch


>diff --git a/mobile/android/base/TabsTray.java b/mobile/android/base/TabsTray.java
>+
>+        // 100 for the item + 2 for divider
>+        sListItemHeight = (int) (102 * metrics.density);
>+        sAddTabHeight = (int) (50 * metrics.density); 

Make 3 consts for these values?
Attachment #595156 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/144e1a03e60d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Will it land on Aurora and Beta?
Verified fixed on Firefox trunk on the Samsung Nexus One.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.