722278 - After closing tab on overflowing tab list popup, empty space remains

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: Screenshot of bug

Steps to reproduce:
- Open up 4 tabs, so tab list popup overflows
- Close 2nd and 3rd tab

Expected result:
- 2 tabs remain in the tab list, no empty space at bottom of tab list popup

Actual result:
- 2 tabs remain in the tab list, empty space at bottom of tab list popup remains

Tested on current Native trunk build on the LG Optimus Black, Android 2.2.2, portrait mode.

Comment 1

[Aaron Train [:aaronmt]]

CC'ing :sriram.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This somehow requires way too many calculations :(
This is found to work the way UX team wants.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 595156 [details] [diff] [review]
Patch


>diff --git a/mobile/android/base/TabsTray.java b/mobile/android/base/TabsTray.java
>+
>+        // 100 for the item + 2 for divider
>+        sListItemHeight = (int) (102 * metrics.density);
>+        sAddTabHeight = (int) (50 * metrics.density); 

Make 3 consts for these values?

Comment 4

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/144e1a03e60d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/144e1a03e60d

Comment 6

[Cristian Nicolae (:xti)]

Will it land on Aurora and Beta?

Comment 7

[Martijn Wargers (dead)]

Verified fixed on Firefox trunk on the Samsung Nexus One.