The default bug view has changed. See this FAQ.

Remove contentAreaClick's redundant return value

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: Veeraya Pupatwibul)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=js] )

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
contentAreaClick always returns true. This isn't useful. It should stop returning something and our three callers should stop reading the return value:

http://mxr.mozilla.org/mozilla-central/search?string=contentAreaClick%28e
(Assignee)

Comment 1

5 years ago
Hi, I'd like to work on this bug. It's my first attempt at fixing bugs. Could someone please mentor me? I already have the source code from https://developer.mozilla.org/En/Simple_Firefox_build. What's next? Make patches and attach them here? Thank you!
(Reporter)

Comment 2

5 years ago
(In reply to Veeraya Pupatwibul from comment #1)
> What's next? Make patches and attach them here?

Yes. :) Have you seen <https://developer.mozilla.org/en/Creating_a_patch>?
(In reply to Veeraya Pupatwibul from comment #1)
> Hi, I'd like to work on this bug. It's my first attempt at fixing bugs.
> Could someone please mentor me? I already have the source code from
> https://developer.mozilla.org/En/Simple_Firefox_build. What's next? Make
> patches and attach them here? Thank you!

I'll assign it to you. If, for some reason, you don't want to work on this anymore, I can take it ;)
Assignee: nobody → pookveeraya
(Assignee)

Comment 4

5 years ago
Created attachment 595455 [details] [diff] [review]
first patch to Bug 722305

First patch. Function now doesn't return any value and callers don't read return value anymore. Hope I did it correctly:)
Attachment #595455 - Flags: review?(dao)
(Reporter)

Comment 5

5 years ago
Comment on attachment 595455 [details] [diff] [review]
first patch to Bug 722305

>   // Mark the page as a user followed link.  This is done so that history can
>   // distinguish automatic embed visits from user activated ones.  For example
>   // pages loaded in frames are embed visits and lost with the session, while
>   // visits across frames should be preserved.
>   try {
>     PlacesUIUtils.markPageAsFollowedLink(href);
>   } catch (ex) { /* Skip invalid URIs. */ }
> 
>-  return true;
>+  return;
> }

nit: remove this final return, as it's a no-op now
Attachment #595455 - Flags: review?(dao) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 595718 [details] [diff] [review]
2nd patch

remove the final return
Attachment #595455 - Attachment is obsolete: true
Attachment #595718 - Flags: review?(dao)
(Reporter)

Comment 7

5 years ago
Comment on attachment 595718 [details] [diff] [review]
2nd patch

perfect, thanks!
Attachment #595718 - Flags: review?(dao) → review+
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=dao][lang=js] → [good first bug][mentor=dao][lang=js] [autoland-try]

Updated

5 years ago
Whiteboard: [good first bug][mentor=dao][lang=js] [autoland-try] → [good first bug][mentor=dao][lang=js] [autoland-in-queue]

Comment 8

5 years ago
Autoland Patchset:
	Patches: 595718
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/a404e743e1db
Try run started, revision a404e743e1db. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=a404e743e1db

Comment 9

5 years ago
Try run for a404e743e1db is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a404e743e1db
Results (out of 211 total builds):
    success: 179
    warnings: 18
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-a404e743e1db

Updated

5 years ago
Whiteboard: [good first bug][mentor=dao][lang=js] [autoland-in-queue] → [good first bug][mentor=dao][lang=js]
(Reporter)

Comment 10

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f8e9d1339b7b
Keywords: checkin-needed
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/f8e9d1339b7b

Congratulations on your first patch in the tree! Hope to see you on IRC (http://irc.mozilla.org/) in #developers soon :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.