722305 - Remove contentAreaClick's redundant return value

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

contentAreaClick always returns true. This isn't useful. It should stop returning something and our three callers should stop reading the return value:

http://mxr.mozilla.org/mozilla-central/search?string=contentAreaClick%28e

Comment 1

[Veeraya Pupatwibul]

Hi, I'd like to work on this bug. It's my first attempt at fixing bugs. Could someone please mentor me? I already have the source code from https://developer.mozilla.org/En/Simple_Firefox_build. What's next? Make patches and attach them here? Thank you!

Comment 2

[Dão Gottwald [:dao]]

(In reply to Veeraya Pupatwibul from comment #1)
> What's next? Make patches and attach them here?

Yes. :) Have you seen <https://developer.mozilla.org/en/Creating_a_patch>?

Comment 3

[Tobias (:Tobbi) Markus]

(In reply to Veeraya Pupatwibul from comment #1)
> Hi, I'd like to work on this bug. It's my first attempt at fixing bugs.
> Could someone please mentor me? I already have the source code from
> https://developer.mozilla.org/En/Simple_Firefox_build. What's next? Make
> patches and attach them here? Thank you!

I'll assign it to you. If, for some reason, you don't want to work on this anymore, I can take it ;)

Comment 4

[Veeraya Pupatwibul]

Attachment: first patch to Bug 722305

First patch. Function now doesn't return any value and callers don't read return value anymore. Hope I did it correctly:)

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 595455 [details] [diff] [review]
first patch to Bug 722305

>   // Mark the page as a user followed link.  This is done so that history can
>   // distinguish automatic embed visits from user activated ones.  For example
>   // pages loaded in frames are embed visits and lost with the session, while
>   // visits across frames should be preserved.
>   try {
>     PlacesUIUtils.markPageAsFollowedLink(href);
>   } catch (ex) { /* Skip invalid URIs. */ }
> 
>-  return true;
>+  return;
> }

nit: remove this final return, as it's a no-op now

Comment 6

[Veeraya Pupatwibul]

Attachment: 2nd patch

remove the final return

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 595718 [details] [diff] [review]
2nd patch

perfect, thanks!

Comment 8

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 595718
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/a404e743e1db
Try run started, revision a404e743e1db. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=a404e743e1db

Comment 9

[Mozilla RelEng Bot]

Try run for a404e743e1db is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a404e743e1db
Results (out of 211 total builds):
    success: 179
    warnings: 18
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a404e743e1db

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f8e9d1339b7b

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f8e9d1339b7b

Congratulations on your first patch in the tree! Hope to see you on IRC (http://irc.mozilla.org/) in #developers soon :-)