722318 - Fix race in connect_to_supplicant

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Right now, nsWifiWorker.js assumes that connect_to_supplicant always returns before the supplicant has made its connection to the network. If this isn't the case, then it doesn't do any sort of DHCP/DNS stuff, leaving the network in an inconsistent state (up but with no IP).

There's an easy fix for this that I'll attach. I had to hack my version of nsWifiWorker.js to even test this fix (since for me connect_to_supplicant always does return before we connect) so if this doesn't work for you, let me know.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This should be pretty straightforward. I also took this opportunity to get rid of the debugging "automatically connect to Mozilla Guest" code. If you think we should leave it in for now, let me know.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 592709 [details] [diff] [review]
Proposed fix

Works for me.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 592709 [details] [diff] [review]
Proposed fix

https://hg.mozilla.org/integration/mozilla-inbound/rev/c52ce509a5c3

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c52ce509a5c3