Closed Bug 722318 Opened 8 years ago Closed 8 years ago

Fix race in connect_to_supplicant

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file)

Right now, nsWifiWorker.js assumes that connect_to_supplicant always returns before the supplicant has made its connection to the network. If this isn't the case, then it doesn't do any sort of DHCP/DNS stuff, leaving the network in an inconsistent state (up but with no IP).

There's an easy fix for this that I'll attach. I had to hack my version of nsWifiWorker.js to even test this fix (since for me connect_to_supplicant always does return before we connect) so if this doesn't work for you, let me know.
Attached patch Proposed fixSplinter Review
This should be pretty straightforward. I also took this opportunity to get rid of the debugging "automatically connect to Mozilla Guest" code. If you think we should leave it in for now, let me know.
Attachment #592709 - Flags: review?(gal)
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 592709 [details] [diff] [review]
Proposed fix

Works for me.
Attachment #592709 - Flags: feedback+
Attachment #592709 - Flags: review?(gal) → review+
https://hg.mozilla.org/mozilla-central/rev/c52ce509a5c3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.