Closed Bug 722348 Opened 8 years ago Closed 8 years ago

remove JSRuntime::requestCount

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: igor, Assigned: igor)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

With single-threaded runtime JSRuntime::requestCount is no longer necessary as the use of the counter can be replaced with checking if JSRuntime::requestDepth >= 0.
Attached patch v1Splinter Review
Besides removing JSRuntime::requestCount the patch also removes unused js_NextActiveContext and requires that js_DestroyContext should be called outside the request. This is to allow to simplify s_DestroyContext and minimize other patches for bug 722345.
Attachment #592742 - Flags: review?
Note: empty r?
Attachment #592742 - Flags: review? → review?(luke)
Comment on attachment 592742 [details] [diff] [review]
v1

Great

>+        } else if (mode == JSDCM_FORCE_GC) {
>+            js_GC(cx, NULL, GC_NORMAL, gcreason::DESTROY_CONTEXT);
>+        } else if (mode == JSDCM_MAYBE_GC) {
>                 JS_MaybeGC(cx);

unindent
Attachment #592742 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/b7e5bbe0003d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.