remove JSRuntime::requestCount

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

unspecified
mozilla12
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
With single-threaded runtime JSRuntime::requestCount is no longer necessary as the use of the counter can be replaced with checking if JSRuntime::requestDepth >= 0.
(Assignee)

Comment 1

6 years ago
Created attachment 592742 [details] [diff] [review]
v1

Besides removing JSRuntime::requestCount the patch also removes unused js_NextActiveContext and requires that js_DestroyContext should be called outside the request. This is to allow to simplify s_DestroyContext and minimize other patches for bug 722345.
Attachment #592742 - Flags: review?

Comment 2

6 years ago
Note: empty r?
(Assignee)

Updated

6 years ago
Attachment #592742 - Flags: review? → review?(luke)

Comment 3

6 years ago
Comment on attachment 592742 [details] [diff] [review]
v1

Great

>+        } else if (mode == JSDCM_FORCE_GC) {
>+            js_GC(cx, NULL, GC_NORMAL, gcreason::DESTROY_CONTEXT);
>+        } else if (mode == JSDCM_MAYBE_GC) {
>                 JS_MaybeGC(cx);

unindent
Attachment #592742 - Flags: review?(luke) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7e5bbe0003d
https://hg.mozilla.org/mozilla-central/rev/b7e5bbe0003d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.