722348 - remove JSRuntime::requestCount

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

With single-threaded runtime JSRuntime::requestCount is no longer necessary as the use of the counter can be replaced with checking if JSRuntime::requestDepth >= 0.

Comment 1

[Igor Bukanov]

Attachment: v1

Besides removing JSRuntime::requestCount the patch also removes unused js_NextActiveContext and requires that js_DestroyContext should be called outside the request. This is to allow to simplify s_DestroyContext and minimize other patches for bug 722345.

Comment 2

[Luke Wagner [:luke]]

Note: empty r?

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 592742 [details] [diff] [review]
v1

Great

>+        } else if (mode == JSDCM_FORCE_GC) {
>+            js_GC(cx, NULL, GC_NORMAL, gcreason::DESTROY_CONTEXT);
>+        } else if (mode == JSDCM_MAYBE_GC) {
>                 JS_MaybeGC(cx);

unindent

Comment 4

[Igor Bukanov]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7e5bbe0003d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b7e5bbe0003d