722368 - Report slow SQL created from dynamic strings to Telemetry

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Vladan Djeric (:vladan)]

As a privacy safeguard, we are currently only reporting on the slow execution of prepared SQL statements. Consequently we are missing a lot of time-consuming SQL created from dynamic strings. We should investigate collecting metrics on such SQL and perhaps reporting only its JavaScript call stack instead of the actual SQL string.

Comment 1

[Vladan Djeric (:vladan)]

Attachment: Report full SQL strings locally & aggregate private stats for Telemetry, v1

Comment 2

[Vladan Djeric (:vladan)]

Attachment: Sample about:telemetry output and corresponding Telemetry Ping report

Comment 3

[Vladan Djeric (:vladan)]

Attachment: about-telemetry change

Comment 4

[Vladan Djeric (:vladan)]

Attachment: New about-telemetry, v0.9.2

Comment 5

[(dormant account)]

Comment on attachment 602352 [details] [diff] [review]
about-telemetry change

s/fullSlowSQL/debugSlowSQL/. I'm still pondering rest of the stuff

Comment 6

[(dormant account)]

Comment on attachment 602234 [details]
Sample about:telemetry output and corresponding Telemetry Ping report

I'm not sure of utility of telling addon dbs apart from non-addon dbs within the ping.

For now we should report a cumulative number like "dynamic query on x.sqlite"

We should also add a toolkit.telemetry.debugSlowSQL=false pref and gate private sql recording on that.

Comment 7

[(dormant account)]

Comment on attachment 602230 [details] [diff] [review]
Report full SQL strings locally & aggregate private stats for Telemetry, v1

r- based on irc discussion

Comment 8

[Vladan Djeric (:vladan)]

Attachment: about-telemetry change, v2

Comment 9

[Vladan Djeric (:vladan)]

Attachment: New about-telemetry, v0.9.2

Comment 10

[Vladan Djeric (:vladan)]

Attachment: Report full SQL strings locally & aggregate private stats for Telemetry, v2

Comment 11

[Vladan Djeric (:vladan)]

Attachment: Sample about:telemetry output, v2

Comment 12

[(dormant account)]

Comment on attachment 603909 [details] [diff] [review]
Report full SQL strings locally & aggregate private stats for Telemetry, v2

AddonDb -> TrackedDB

+    fullSql.AppendPrintf(" /* addon DB %s */", dbName.BeginReading());

-- is the proper comment prefix for SQL.
s/addon/untracked/

Comment 13

[Vladan Djeric (:vladan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b411890365e8

Comment 14

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b411890365e8