Upgrade to zlib 1.2.6

RESOLVED FIXED in mozilla14

Status

()

Core
General
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dholbert, Assigned: Daniel Jeter II)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Looks like zlib released a new version 1.2.6, 2 days ago.  We're currently on 1.2.5, last updated in bug 573137.

From http://www.zlib.net/ :
{{
Version 1.2.6 has many changes over 1.2.5, including these improvements:

    gzread() can now read a file that is being written concurrently
    gzgetc() is now a macro for increased speed
    Added a 'T' option to gzopen() for transparent writing (no compression)
    Added deflatePending() to return the amount of pending output
    Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
    deflatePrime() can now insert bits in the middle of the stream
    ./configure now creates a configure.log file with all of the results
    Added a ./configure --solo option to compile zlib with no dependency on any libraries
    Fixed a problem with large file support macros
    Fixed a bug in contrib/puff
    Many portability improvements
}}

Filing this bug to track taking the upgrade (assuming that we want to take the upgrade).
(Reporter)

Updated

6 years ago
(Reporter)

Comment 1

6 years ago
FWIW, our zlib import lives in http://mxr.mozilla.org/mozilla-central/source/modules/zlib/src/
(Assignee)

Comment 2

6 years ago
Created attachment 595458 [details] [diff] [review]
Patch to upgrade zlib to 1.2.6
(Assignee)

Comment 3

5 years ago
Created attachment 595807 [details] [diff] [review]
Updated zlib_patch.diff

Fixed a nit: Define io.h in gzguts.h when __TURBOC__ or _MSC_VER is defined.
Attachment #595458 - Attachment is obsolete: true
Comment on attachment 595807 [details] [diff] [review]
Updated zlib_patch.diff

This won't move anywhere without a review.

Bug 573137 was the last update, reviewed by joe. Joe, if you're not the right one to tackle this further, can you forward to the right person?
Attachment #595807 - Flags: review?(joe)
Comment on attachment 595807 [details] [diff] [review]
Updated zlib_patch.diff

Review of attachment 595807 [details] [diff] [review]:
-----------------------------------------------------------------

I rubber stamp this! Time to put it on try, which I'll cause to happen.
Attachment #595807 - Flags: review?(joe) → review+
Whiteboard: [autoland-try]

Updated

5 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 6

5 years ago
Autoland Patchset:
	Patches: 595807
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=0e450d307865
Try run started, revision 0e450d307865. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=0e450d307865

Comment 7

5 years ago
Try run for 0e450d307865 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0e450d307865
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-0e450d307865

Updated

5 years ago
Whiteboard: [autoland-in-queue]
(Reporter)

Comment 8

5 years ago
Landed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/503a4e4804f0
Assignee: nobody → djeter
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/503a4e4804f0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Blocks: 751697
You need to log in before you can comment on or make changes to this bug.