The default bug view has changed. See this FAQ.

Cleanup nsPlaintextEditor::SetDocumentCharacterSet

RESOLVED FIXED in mozilla13

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 592805 [details] [diff] [review]
Patch v1
Attachment #592805 - Flags: review?(ehsan)
Comment on attachment 592805 [details] [diff] [review]
Patch v1

Review of attachment 592805 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsPlaintextEditor.cpp
@@ +238,5 @@
> +  // update META charset tag
> +  nsCOMPtr<nsIDOMDocument> domdoc;
> +  rv = GetDocument(getter_AddRefs(domdoc));
> +  NS_ENSURE_SUCCESS(rv, rv);
> +  NS_ENSURE_TRUE(domdoc, NS_OK);

NS_ERROR_FAILURE.

@@ +293,3 @@
>  
> +  PRUint32 listLength = 0;
> +  (void) metaList->GetLength(&listLength);

Drop the unneeded cast please.

::: editor/libeditor/text/nsPlaintextEditor.h
@@ +107,5 @@
>    NS_IMETHOD SetDocumentCharacterSet(const nsACString & characterSet);
>  
> +private:
> +  bool UpdateMetaCharset(nsIDOMDocument* aDocument,
> +                         const nsACString& aCharacterSet);

Nit: move this to the end of the public section please.
Attachment #592805 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c346b375b471
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.