Closed
Bug 722412
Opened 13 years ago
Closed 13 years ago
Cleanup nsPlaintextEditor::SetDocumentCharacterSet
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
8.65 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #592805 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 592805 [details] [diff] [review]
Patch v1
Review of attachment 592805 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/text/nsPlaintextEditor.cpp
@@ +238,5 @@
> + // update META charset tag
> + nsCOMPtr<nsIDOMDocument> domdoc;
> + rv = GetDocument(getter_AddRefs(domdoc));
> + NS_ENSURE_SUCCESS(rv, rv);
> + NS_ENSURE_TRUE(domdoc, NS_OK);
NS_ERROR_FAILURE.
@@ +293,3 @@
>
> + PRUint32 listLength = 0;
> + (void) metaList->GetLength(&listLength);
Drop the unneeded cast please.
::: editor/libeditor/text/nsPlaintextEditor.h
@@ +107,5 @@
> NS_IMETHOD SetDocumentCharacterSet(const nsACString & characterSet);
>
> +private:
> + bool UpdateMetaCharset(nsIDOMDocument* aDocument,
> + const nsACString& aCharacterSet);
Nit: move this to the end of the public section please.
Attachment #592805 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•