Last Comment Bug 722416 - Outparamdel nsHTMLCSSUtils::GetElementContainerOrSelf
: Outparamdel nsHTMLCSSUtils::GetElementContainerOrSelf
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-30 11:56 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-02-01 05:46 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (8.42 KB, patch)
2012-01-30 11:56 PST, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-01-30 11:56:07 PST
Created attachment 592808 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-01-30 13:06:17 PST
Comment on attachment 592808 [details] [diff] [review]
Patch v1

Review of attachment 592808 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLCSSUtils.cpp
@@ +1329,3 @@
>  
> +  if (nsIDOMNode::DOCUMENT_NODE == node->NodeType()) {
> +    return NULL;

nsnull!

@@ +1337,3 @@
>    }
> +
> +  NS_ENSURE_TRUE(node, NULL);

Need I say more? ;)
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-02-01 05:46:28 PST
https://hg.mozilla.org/mozilla-central/rev/a343b016963b

Note You need to log in before you can comment on or make changes to this bug.