Cleanup BeginningOfDocument / GetFirstEditableNode

RESOLVED FIXED in mozilla13

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 592810 [details] [diff] [review]
Part a: Introduce another version of GetNextNode
Attachment #592810 - Flags: review?(ehsan)
(Assignee)

Comment 1

6 years ago
Created attachment 592812 [details] [diff] [review]
Part b: BeginningOfDocument / GetFirstEditableNode
Attachment #592812 - Flags: review?(ehsan)
Comment on attachment 592810 [details] [diff] [review]
Part a: Introduce another version of GetNextNode

Review of attachment 592810 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/nsEditor.cpp
@@ +3352,2 @@
>                                                aActiveEditorRoot))) {
> +    return NULL;

nsnull
Attachment #592810 - Flags: review?(ehsan) → review+
Comment on attachment 592812 [details] [diff] [review]
Part b: BeginningOfDocument / GetFirstEditableNode

Review of attachment 592812 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/nsEditor.cpp
@@ +2526,3 @@
>    }
> +
> +  return (node != aRoot) ? node : NULL;

nsnull
Attachment #592812 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/44ca4e835571
https://hg.mozilla.org/mozilla-central/rev/c063be6679fe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.