Closed
Bug 722419
Opened 13 years ago
Closed 13 years ago
Cleanup BeginningOfDocument / GetFirstEditableNode
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files)
|
3.68 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
5.49 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #592810 -
Flags: review?(ehsan)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #592812 -
Flags: review?(ehsan)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 592810 [details] [diff] [review]
Part a: Introduce another version of GetNextNode
Review of attachment 592810 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/base/nsEditor.cpp
@@ +3352,2 @@
> aActiveEditorRoot))) {
> + return NULL;
nsnull
Attachment #592810 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 592812 [details] [diff] [review]
Part b: BeginningOfDocument / GetFirstEditableNode
Review of attachment 592812 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/base/nsEditor.cpp
@@ +2526,3 @@
> }
> +
> + return (node != aRoot) ? node : NULL;
nsnull
Attachment #592812 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44ca4e835571
https://hg.mozilla.org/mozilla-central/rev/c063be6679fe
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•