Last Comment Bug 722419 - Cleanup BeginningOfDocument / GetFirstEditableNode
: Cleanup BeginningOfDocument / GetFirstEditableNode
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-30 12:01 PST by :Ms2ger
Modified: 2012-02-01 05:47 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Introduce another version of GetNextNode (3.68 KB, patch)
2012-01-30 12:01 PST, :Ms2ger
ehsan: review+
Details | Diff | Splinter Review
Part b: BeginningOfDocument / GetFirstEditableNode (5.49 KB, patch)
2012-01-30 12:02 PST, :Ms2ger
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger 2012-01-30 12:01:55 PST
Created attachment 592810 [details] [diff] [review]
Part a: Introduce another version of GetNextNode
Comment 1 :Ms2ger 2012-01-30 12:02:27 PST
Created attachment 592812 [details] [diff] [review]
Part b: BeginningOfDocument / GetFirstEditableNode
Comment 2 :Ehsan Akhgari 2012-01-30 13:19:33 PST
Comment on attachment 592810 [details] [diff] [review]
Part a: Introduce another version of GetNextNode

Review of attachment 592810 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/nsEditor.cpp
@@ +3352,2 @@
>                                                aActiveEditorRoot))) {
> +    return NULL;

nsnull
Comment 3 :Ehsan Akhgari 2012-01-30 13:21:00 PST
Comment on attachment 592812 [details] [diff] [review]
Part b: BeginningOfDocument / GetFirstEditableNode

Review of attachment 592812 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/nsEditor.cpp
@@ +2526,3 @@
>    }
> +
> +  return (node != aRoot) ? node : NULL;

nsnull

Note You need to log in before you can comment on or make changes to this bug.