722454 - ERROR addons.repository: Error creating statement getAllAddons. Breaks add-ons manager, application update, etc.

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Bret Reckard]

Attachment: Updates Dialog

I switched from Nightly to the Release Branch for the run up to release day.  Now, I switched back to nightly, and have tried to find the latest Update from the *nightly* menu.  This method just leaves me with the version-check dialog and a spinning *checking for updates...* message.  The browser never finds this update.

Error Console Log attached.

This profile I less than 1-month old.





Gratuitous system info dump:


  Application Basics

        Name
        Firefox

        Version
        10.0a1

        User Agent
        Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a1) Gecko/20111007 Firefox/10.0a1

        Profile Directory

          Show in Finder

        Enabled Plugins

          about:plugins

        Build Configuration

          about:buildconfig

        Crash Reports

          about:crashes

        Memory Use

          about:memory

  Extensions

        Name

        Version

        Enabled

        ID

  Modified Preferences

      Name

      Value

        accessibility.typeaheadfind.flashBar
        0

        browser.places.smartBookmarksVersion
        2

        browser.startup.homepage_override.buildID
        20111007031227

        browser.startup.homepage_override.mstone
        rv:10.0a1

        extensions.lastAppVersion
        10.0a1

        network.cookie.prefsMigrated
        true

        network.protocol-handler.external.aliph
        true

        network.protocol-handler.warn-external.aliph
        false

        places.database.lastMaintenance
        1327941139

        places.history.expiration.transient_current_max_pages
        100664

        places.history.expiration.transient_optimal_database_size
        161061272

        print.macosx.pagesetup-2
        PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPCFET0NUWVBFIHBsaXN0IFBVQkxJQyAiLS8vQXBwbGUvL0RURCBQTElTVCAxLjAvL0VO…

        privacy.sanitize.migrateFx3Prefs
        true

        security.warn_viewing_mixed
        false

  Graphics

        Vendor ID
        10de

        Device ID
        08a3

        WebGL Renderer
        NVIDIA Corporation -- NVIDIA GeForce 320M OpenGL Engine -- 2.1 NVIDIA-7.12.9

        GPU Accelerated Windows
        3/3 OpenGL

Comment 1

[Robert Strong (they/them - no direct email)]

How are you switching?

Comment 2

[Bret Reckard]

I don't know what that means :(.

I had the Firefox 10.0.a1 nightly installed, and switched to the Firefox 9 build to do some pre-release dog fooding, now that the release is set for tomorrow I wanted to switch back to the Nightlies.  So I closed 9 and opened the old 10.0.a1 build I was running, checked for the update via the *nightly* menu and now it's not finding this update.

Does that help?

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The last message in the screenshot says it found an 1 update. What are the messages after that, if any ?

Comment 4

[Bret Reckard]

That is the last update from the AUS:SVC Checker

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Ok. The content at https://aus3.mozilla.org/update/3/Firefox/10.0a1/20111007031227/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/nightly/Darwin%2011.2.0/default/default/update.xml?force=1 looks sane:

<?xml version="1.0"?>
<updates>
    <update type="minor" version="12.0a1" extensionVersion="12.0a1" buildID="20120130031142">
        <patch type="complete" URL="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/01/2012-01-30-03-11-42-mozilla-central/firefox-12.0a1.en-US.mac.complete.mar" hashFunction="sha512" hashValue="8a9ef627c7fe6a4b36f1bd4163adeb71f7dc4226b2d621641b2d7d2a81c1d3b96f1c62c8ea80ca3dd052908a9c9aacf81da85e5deb79f3625062c7f05075b85e" size="38687032"/>
    </update>
</updates>

so looks like something in the updater service.

Comment 6

[Robert Strong (they/them - no direct email)]

There have been a couple of add-ons that break the add-ons manager that then breaks the update service. Could you try launching in safe mode and then checking for updates?

Comment 7

[Bret Reckard]

Attachment: Error Log in safe mode, still not finding update.

Still not finding update in Safe mode.

Comment 8

[Robert Strong (they/them - no direct email)]

Please attach the active-update.xml using the following instructions to find the file (paths are for a default nightly install):

Open the Applications folder
control click Nightly. Select Show Package Contents
Open Contents
Open MacOS
Open updates

Comment 9

[Bret Reckard]

Attachment: xml file

This xml file was not in the updates directory, it was in MacOS.  If that matters.  Otherwise, attached.

Comment 10

[Robert Strong (they/them - no direct email)]

That was my mistake. Strangely the update info isn't being saved to that file. Could you also attach the updates.xml which is in the same directory as the active-update.xml file.

Comment 11

[Bret Reckard]

Attachment: updates.xml

updates.xml attached

Comment 12

[Robert Strong (they/them - no direct email)]

I'll be in the MV office a couple of days next week. Can I come by and take a look since the logs haven't provided any insight?

Comment 13

[Bret Reckard]

Maybe related:

Also remembered that the "Checking for compatible add-ons" spinner also never completed it's check upon the initial change from Release to Nightly.  I had to force-quit then restart and there was no check the second time Nightly loaded.

Comment 14

[Robert Strong (they/them - no direct email)]

note: talked with Bret and will be meeting up with him in MV next week.

Comment 15

[Bret Reckard]

Spoke with Blair McBride today on IRC.  I was having issues with installing an addon (downloads didn't complete) and checking installed addons (never connected to my list of addons).  This seems related.

Blair suggested that I change the extensions.getAddons.cache.enabled to false and try installing the addon.  Success!

Now this also seems to have solved the problem of not finding updates and connecting to the addons site via the browser.

Comment 16

[Robert Strong (they/them - no direct email)]

Blair, do you know why extensions.getAddons.cache.enabled, true would break app update for Bret?

Comment 17

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Presumably it's breaking something in AddonRepository, but I'd expect to see something in the logs. And I have no idea why that would break app-update at that stage (but I only have a very rough understanding of app update).

Bret: Could you attach the addons.sqlite file in your profile directory?

And if we don't find anything odd in that... Since Bret is in the MV office, I suspect the easiest way to sort this out is for you or Dave (hi Dave!) to just physically go to the machine and poke about.

Comment 18

[Robert Strong (they/them - no direct email)]

Bret, could you flip that pref back and check if app update continues to not work? Thanks

Comment 19

[Bret Reckard]

Flipped the perf back to False and it reverts to the non-updating state

Comment 20

[Bret Reckard]

LOG addons.xpi: Opening database

LOG addons.repository: Deleting database, and attempting openConnection again

Error: ERROR addons.repository: Error creating statement getAllAddons (SELECT internal_id, id, type, name, version, creator, creatorURL, description, fullDescription, developerComments, eula, iconURL, homepageURL, supportURL, contributionURL, contributionAmount, averageRating, reviewCount, reviewURL, totalDownloads, weeklyDownloads, dailyUsers, sourceURI, repositoryStatus, size, updateDate FROM addon)
Source File: resource://gre/modules/AddonRepository.jsm
Line: 1428

Error: this is undefined
Source File: resource://gre/modules/AddonRepository.jsm
Line: 1297

Comment 21

[Robert Strong (they/them - no direct email)]

The contents of comment #20 was reported to the error console in safe mode. I am going to make this an add-ons manager bug so the root cause can be diagnosed and fixed if it isn't already. I'll file a bug to add more protections to application update in the hope of preventing the add-ons manager from breaking it.

Blair, can you work with Bret to try to find out why the add-ons manager breaks on his system?

Comment 22

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Sorry for the lag here :( Been crazy busy lately.

Were the errors in comment 20 from the same 10.0a1 build you were using when you first had issues, or did you update to the latest nightly and see those errors?

Either way, could you attach your extensions.sqlite and addons.sqlite files, found in your profile directory?

Then, if you haven't updated, could you?

If you had updated... then I'll very confused.

Comment 23

[Blair McBride [:Unfocused] (UNAVAILABLE)]

To be explicitly clear: If you haven't updated, attach the extensions.sqlite and addons.sqlite files *BEFORE* updating. Please :)

Comment 24

[Bret Reckard]

Attachment: addons.sqlite (before upgrade)

Comment 25

[Bret Reckard]

Attachment: extensions.sqlite (before upgrade)

Comment 26

[Bret Reckard]

I've not updated, so ping me later today if you need anything else.  Happy to help.

Comment 27

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bret: Any update on this? (Been waiting to hear back about any errors after you updated, and re-enabled that pref.)

Comment 28

[Bret Reckard]

Hey Blair, I was holding off on updating until hearing from you.  Little miscommunication there.

* Just updated to 14.0a1 (2012-03-14)
* Set extensions.getAddons.cache.enabled, true

Everything seems to be working just fine now.  Can view addons, use PDF.js etc.

Anything else you'd like from me?

Comment 29

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Excellent, thanks :) 

We had done some work to make that more resilient, and that seems to have paid off. I'll count this as fixed then.


For future reference, if anyone else encounters this on a version of Firefox earlier than Firefox 10, the solution is to:
* Open about:config
* Set extensions.getAddons.cache.enabled to false
* Update Firefox
* Set extensions.getAddons.cache.enabled to true