The default bug view has changed. See this FAQ.

Remove no-longer-used argument from nsBlockFrame::DrainOverflowLines(nsBlockReflowState& aState)

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Block and Inline
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The method
   nsBlockFrame::DrainOverflowLines(nsBlockReflowState& aState)
no longer uses its argument aState.

These csets removed the last usages, as part of bug 492627:
http://hg.mozilla.org/mozilla-central/diff/28008648ca04/layout/generic/nsBlockFrame.cpp#l1.185
http://hg.mozilla.org/mozilla-central/diff/e9130436ada8/layout/generic/nsBlockFrame.cpp#l1.436

It looks like we can just take DrainOverflowLines() argumentless now.
(Assignee)

Comment 1

5 years ago
Created attachment 592876 [details] [diff] [review]
fix v1

I think this'll do it. (haven't finished rebuilding yet though)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #592876 - Flags: review?(roc)
Attachment #592876 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/94bae0abad47
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/94bae0abad47
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.