722532 - Large play button shows in <audio controls>

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Audio elements with controls are showing the "large play button" added in bug 666306. That looks kinda weird, and increases the size of the audio element.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

If we can't fix this before the Aurora uplift tomorrow, we should back out bug 666306 of Aurora (after the uplift) so that we don't end up shipping this as a regression in Fx12.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Chris Pearce (:cpearce) from comment #1)
> If we can't fix this before the Aurora uplift tomorrow, we should back out
> bug 666306 of Aurora (after the uplift) so that we don't end up shipping
> this as a regression in Fx12.

If the fix lands after the merge (the most likely and safe route), then I don't see an issue requesting aurora-approval. I think we should only backout bug 666306 if aurora-approval isn't granted.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Sure, the fix should be trivial and safe enough to take on Aurora. :)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 593627 [details] [diff] [review]
Patch for bug

Yeah, this should be quite safe to take on Aurora.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/17ab81ec8669

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/17ab81ec8669

Comment 8

[Alex Keybl [:akeybl]]

Please nominate for Aurora 12 approval now that we've had some bake time on m-c.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 593627 [details] [diff] [review]
Patch for bug

[Approval Request Comment]
Regression caused by (bug #): bug 666306
User impact if declined: websites that use <audio> tag may have broken layouts
Testing completed (on m-c, etc.): this has baked on m-c since 2/4
Risk to taking this patch (and alternatives if risky): no risk expected
String changes made by this patch: none

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 593627 [details] [diff] [review]
Patch for bug

[Triage Comment]
Approved for Aurora 12.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1ca688e9a4a

Comment 12

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0
20120403211507