722541 - Standardize on a single random number generator

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[David Chan [:dchan]]

There are at least 3 ways for generating random data in the current JPAKE code. [1] uses SecureRandom, [2] and [3] use Random.

At the very least, [2] and [3] could be combined into one function.

createSecret in JPakeClient.java may need to use secure random [4]


[1] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeNumGeneratorRandom.java#L49
[2] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeClient.java#L1145
[3]] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeUtils.java#L44
[4] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeClient.java#L1070

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

All of these must use a secure PRNG. The clientID stuff is a little less clear as to the necessity, but I think a secure PRNG doesn't hurt and at least theoretically should help make DoS attacks that require guessing the client ID more difficult.

Comment 2

[Richard Newman [:rnewman]]

Fixed in develop:

https://github.com/mozilla-services/android-sync/commit/7721c1c50f28113ddd0db235894175e317c41a41

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1bfbf78359af