722551 - Freezing function proxies doesn't work.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: test case: Once a function proxy has been frozen, operating on it should not cause its trap handlers to be called.

Function proxies' trap handlers can get called even after they've been frozen:

    $ cat ~/moz/fproxy.js
    function x() {}
    var handler = {
        getOwnPropertyNames: function () {
            print("Hi!");
            return[];
        },
        fix:function(){ return{} }
    };
    var fp = Proxy.createFunction(handler,x,x);
    Object.freeze(fp);
    print("Frozen.");
    Object.getOwnPropertyNames(fp);
    $ obj~/js -f ~/moz/fproxy.js
    Hi!
    Frozen.
    Hi!
    $

Comment 1

[Jim Blandy :jimb]

Try: https://tbpl.mozilla.org/?tree=Try&rev=2ba50d492112

Comment 2

[Jim Blandy :jimb]

Attachment: Once a function proxy has been frozen, operating on it should not cause its trap handlers to be called.

Comment 3

[Andreas Gal :gal]

Comment on attachment 592986 [details] [diff] [review]
Once a function proxy has been frozen, operating on it should not cause its trap handlers to be called.

Those are some pretty tests. Made my day to read them.

Comment 4

[Jim Blandy :jimb]

(In reply to Andreas Gal :gal from comment #3)
> Comment on attachment 592986 [details] [diff] [review]
> Once a function proxy has been frozen, operating on it should not cause its
> trap handlers to be called.
> 
> Those are some pretty tests. Made my day to read them.

For a one-line change, too. :) Thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/cface840992d
That changeset log message omits the r=gal; apologies, folks.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cface840992d