Last Comment Bug 722552 - Remove xul panel for html tree from browser.xul
: Remove xul panel for html tree from browser.xul
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 13
Assigned To: Nobody; OK to take it and work on it
:
: Patrick Brosset <:pbro>
Mentors:
Depends on: 719607
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-30 16:14 PST by Rob Campbell [:rc] (:robcee)
Modified: 2012-02-27 01:20 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Made a patch removing the lines (1.40 KB, patch)
2012-02-03 10:17 PST, Alexandre Negrao
no flags Details | Diff | Splinter Review
New patch with the inspectPanelTitle.label removed also (2.49 KB, patch)
2012-02-03 11:16 PST, Alexandre Negrao
rcampbell: review+
Details | Diff | Splinter Review

Description Rob Campbell [:rc] (:robcee) 2012-01-30 16:14:47 PST
<panel id="inspector-tree-panel"
           orient="vertical"
           hidden="true"
           ignorekeys="true"
           noautofocus="true"
           noautohide="true"
           titlebar="normal"
           close="true"
           label="&inspectPanelTitle.label;">
      <hbox id="tree-panel-resizer-box" align="end">
        <spacer flex="1" />
        <resizer dir="bottomend" />
      </hbox>
    </panel>
Comment 1 Alexandre Negrao 2012-02-03 10:17:18 PST
Created attachment 594234 [details] [diff] [review]
Made a patch removing the lines
Comment 2 Dão Gottwald [:dao] 2012-02-03 10:35:52 PST
Comment on attachment 594234 [details] [diff] [review]
Made a patch removing the lines

This makes inspectPanelTitle.label unused. Please remove it from browser/locales/en-US/chrome/browser/browser.dtd.
Comment 3 Alexandre Negrao 2012-02-03 11:16:07 PST
Created attachment 594252 [details] [diff] [review]
New patch with the inspectPanelTitle.label removed also
Comment 4 Rob Campbell [:rc] (:robcee) 2012-02-10 19:32:36 PST
Comment on attachment 594252 [details] [diff] [review]
New patch with the inspectPanelTitle.label removed also

Looks good. Thanks for the patch!
Comment 5 Rob Campbell [:rc] (:robcee) 2012-02-10 19:36:43 PST
We'll have to land this after bug 719607 lands.
Comment 6 Paul Rouget [:paul] 2012-02-24 14:05:24 PST
https://hg.mozilla.org/integration/fx-team/rev/59c3980dbdbc
Comment 7 Tim Taubert [:ttaubert] 2012-02-27 01:20:53 PST
https://hg.mozilla.org/mozilla-central/rev/59c3980dbdbc

Note You need to log in before you can comment on or make changes to this bug.