Closed Bug 722553 Opened 8 years ago Closed 8 years ago

JPakeClient.java onRequestSuccess exception block handling

Categories

(Firefox for Android :: Android Sync, defect, P3)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: dchanm+bugzilla, Assigned: nalexander)

References

Details

(Whiteboard: [qa-])

The exception handling in onRequestSuccess seems inconsistent. Certain exceptions will cause an abort() in some parts of the code but not others [1]

A NonObjectJSONException from
800        jIncoming = response.jsonObjectBody();
will cause an abort but the same exception from
821          if (verifyPairing(jIncoming, myKeyBundle)) {
will print a stack trace.


What defines when an exception is fatal?


[1] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeClient.java#L791
Blocks: 723230
Assignee: nobody → liuche
Assignee: liuche → nalexander
Priority: -- → P3
https://hg.mozilla.org/services/services-central/rev/6f1239da8d0e
Status: NEW → ASSIGNED
Whiteboard: [fixed in services][qa-]
https://hg.mozilla.org/mozilla-central/rev/92b773c99586
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/6f1239da8d0e
Whiteboard: [fixed in services][qa-] → [qa-]
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.