Closed
Bug 722553
Opened 12 years ago
Closed 12 years ago
JPakeClient.java onRequestSuccess exception block handling
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: dchanm+bugzilla, Assigned: nalexander)
References
Details
(Whiteboard: [qa-])
The exception handling in onRequestSuccess seems inconsistent. Certain exceptions will cause an abort() in some parts of the code but not others [1] A NonObjectJSONException from 800 jIncoming = response.jsonObjectBody(); will cause an abort but the same exception from 821 if (verifyPairing(jIncoming, myKeyBundle)) { will print a stack trace. What defines when an exception is fatal? [1] - https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeClient.java#L791
Updated•12 years ago
|
Assignee: nobody → liuche
Assignee | ||
Updated•12 years ago
|
Assignee: liuche → nalexander
Updated•12 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•12 years ago
|
||
Merged in develop: https://github.com/mozilla-services/android-sync/commit/fe693ca8755706456fc36084d45ce08e949d2389
Comment 2•12 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/6f1239da8d0e
Status: NEW → ASSIGNED
Whiteboard: [fixed in services][qa-]
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/92b773c99586
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6f1239da8d0e
Whiteboard: [fixed in services][qa-] → [qa-]
Updated•11 years ago
|
Product: Mozilla Services → Android Background Services
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•