The default bug view has changed. See this FAQ.

no_such_method_trace (trace function for NoSuchMethod objects) is unnecessary

RESOLVED FIXED in mozilla13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimb, Unassigned)

Tracking

Trunk
mozilla13
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 592996 [details] [diff] [review]
Remove custom trace function from js_NoSuchMethodClass.

This is kind of embarrassing, but:

Since js_NoSuchMethodClass is a native class, it doesn't need a custom trace function; the normal slot traversal will reach the function and id slots. I've verified this in the debugger, and will later be proposing a patch that actually verifies that the slots are being marked properly.
(Reporter)

Comment 1

5 years ago
Try: https://tbpl.mozilla.org/?tree=Try&rev=fa7f1b5bc7e0

I've also run all the tests in js/src/tests and js/src/jit-test that use __noSuchMethod__ with --gczeal=1 and --gczeal=2; seems fine.
(Reporter)

Updated

5 years ago
Attachment #592996 - Flags: review?(jwalden+bmo)
Attachment #592996 - Flags: review?(jwalden+bmo) → review+
(Reporter)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=fc6b5d8a8001
Status: NEW → ASSIGNED
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
(Reporter)

Comment 3

5 years ago
Rather:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6b5d8a8001
https://hg.mozilla.org/mozilla-central/rev/fc6b5d8a8001
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.