Closed
Bug 722622
Opened 13 years ago
Closed 13 years ago
no_such_method_trace (trace function for NoSuchMethod objects) is unnecessary
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jimb, Unassigned)
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
This is kind of embarrassing, but:
Since js_NoSuchMethodClass is a native class, it doesn't need a custom trace function; the normal slot traversal will reach the function and id slots. I've verified this in the debugger, and will later be proposing a patch that actually verifies that the slots are being marked properly.
|
Reporter | |
Comment 1•13 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=fa7f1b5bc7e0
I've also run all the tests in js/src/tests and js/src/jit-test that use __noSuchMethod__ with --gczeal=1 and --gczeal=2; seems fine.
|
|
Reporter | |
Updated•13 years ago
|
Attachment #592996 -
Flags: review?(jwalden+bmo)
|
||
Updated•13 years ago
|
Attachment #592996 -
Flags: review?(jwalden+bmo) → review+
|
|
Reporter | |
Comment 2•13 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
|
|
Reporter | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•