Closed
Bug 722639
Opened 13 years ago
Closed 13 years ago
Needs some automated tests for bug 692145
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod)
Attachments
(1 file)
6.26 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I have no idea to test the actual cause of bug 692145 directly.
However, I think that we can test something related of the bug:
1. Add NS_ABORT_IF_FALSE() into the CountNewlinesIn*().
2. Insert a lot of lines in <textarea>
3. Do query the text rect of each line's start.
Then, between the each line's y should be same distance (might be different 1px by subpixel positioning though).
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #593319 -
Flags: review?(ehsan)
Comment 2•13 years ago
|
||
Comment on attachment 593319 [details] [diff] [review]
Patch
Review of attachment 593319 [details] [diff] [review]:
-----------------------------------------------------------------
The 1px tolerance is fragile. Can't you just store the last item's .top+.height, and verify that the .top of the next element is greater than that value?
Attachment #593319 -
Flags: review?(ehsan)
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> The 1px tolerance is fragile. Can't you just store the last item's
> .top+.height, and verify that the .top of the next element is greater than
> that value?
Hmm, no, it isn't. On Linux, lines may be overlapped each other. Actually, lines overlap each other 2px on tryserver. It's valid for CSS and not a problem for composition.
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 593319 [details] [diff] [review]
Patch
requesting r again for my previous comment.
Attachment #593319 -
Flags: review?(ehsan)
Comment 5•13 years ago
|
||
Comment on attachment 593319 [details] [diff] [review]
Patch
OK, fair enough!
Attachment #593319 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Whiteboard: [inbound]
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•