Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Needs some automated tests for bug 692145

RESOLVED FIXED in mozilla13

Status

()

Core
Event Handling
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla13
x86
Windows 7
inputmethod
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I have no idea to test the actual cause of bug 692145 directly.

However, I think that we can test something related of the bug:

1. Add NS_ABORT_IF_FALSE() into the CountNewlinesIn*().
2. Insert a lot of lines in <textarea>
3. Do query the text rect of each line's start.

Then, between the each line's y should be same distance (might be different 1px by subpixel positioning though).
Created attachment 593319 [details] [diff] [review]
Patch
Attachment #593319 - Flags: review?(ehsan)
Comment on attachment 593319 [details] [diff] [review]
Patch

Review of attachment 593319 [details] [diff] [review]:
-----------------------------------------------------------------

The 1px tolerance is fragile.  Can't you just store the last item's .top+.height, and verify that the .top of the next element is greater than that value?
Attachment #593319 - Flags: review?(ehsan)
(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> The 1px tolerance is fragile.  Can't you just store the last item's
> .top+.height, and verify that the .top of the next element is greater than
> that value?

Hmm, no, it isn't. On Linux, lines may be overlapped each other. Actually, lines overlap each other 2px on tryserver. It's valid for CSS and not a problem for composition.
Comment on attachment 593319 [details] [diff] [review]
Patch

requesting r again for my previous comment.
Attachment #593319 - Flags: review?(ehsan)
Comment on attachment 593319 [details] [diff] [review]
Patch

OK, fair enough!
Attachment #593319 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/08b3c9d38e32
Whiteboard: [inbound]
Target Milestone: --- → mozilla13

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/08b3c9d38e32
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.