buttons are too close to edge

RESOLVED FIXED in 1.5

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

Trunk
x86_64
Windows 7

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Created attachment 593082 [details]
spacing - current and proposed

The spacing in the New event dialog is slightly off.
The first button is too close to the left edge and all of the buttons are too close to the bottom edge. Especially compared to the calendar toolbar.
(Assignee)

Comment 1

7 years ago
Created attachment 593917 [details]
Fix the negative margin

The Tabs-on-top patch introduced for the .chromeclass-toolbar a negative margin. This patch fixes this.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #593917 - Flags: ui-review?(nisses.mail)
Attachment #593917 - Flags: review?(nisses.mail)
(Reporter)

Comment 2

7 years ago
Comment on attachment 593917 [details]
Fix the negative margin

I think it needs some padding-bottom of 2px added as well.
ui-r and r plus with that fixed.
Attachment #593917 - Flags: ui-review?(nisses.mail)
Attachment #593917 - Flags: ui-review-
Attachment #593917 - Flags: review?(nisses.mail)
Attachment #593917 - Flags: review-
(Assignee)

Comment 3

7 years ago
Created attachment 593954 [details] [diff] [review]
Fix the negative margin v2

I gave now on top a padding of 1px and on bottom 2px.
Attachment #593917 - Attachment is obsolete: true
Attachment #593954 - Flags: ui-review?(nisses.mail)
Attachment #593954 - Flags: review?(nisses.mail)
(Reporter)

Comment 4

7 years ago
Comment on attachment 593954 [details] [diff] [review]
Fix the negative margin v2

Works great!
Attachment #593954 - Flags: ui-review?(nisses.mail)
Attachment #593954 - Flags: ui-review+
Attachment #593954 - Flags: review?(nisses.mail)
Attachment #593954 - Flags: review+
(Assignee)

Comment 5

7 years ago
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/d950eae8189d>
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
(Assignee)

Comment 6

7 years ago
Comment on attachment 593954 [details] [diff] [review]
Fix the negative margin v2

Because the negative margin was introduced by the tabs-on-top patch, this patch should also go to aurora and beta.
Attachment #593954 - Flags: approval-calendar-beta?
Attachment #593954 - Flags: approval-calendar-aurora?
Comment on attachment 593954 [details] [diff] [review]
Fix the negative margin v2

Removing outdated approval flags. Since time of request the patch has matured to comm-beta already and will be released with Lightning 1.5 soon.
Attachment #593954 - Flags: approval-calendar-beta?
Attachment #593954 - Flags: approval-calendar-aurora?
You need to log in before you can comment on or make changes to this bug.