722719 - Please change mozconfig for Nightly and Aurora to use SDK 14

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We need this to build the Flash support that is now in inbound (oops)

Comment 1

[Mike Taylor [:bear]]

Attachment: change android mozconfig to reference sdk 14

per Blassey in IRC - this change is for all mozconfigs

[11:24]  <bear> try, m-c  only?
[11:24]  <snorp> m-i
[11:24]  <snorp> also m-a
[11:25]  <blassey> bear: across the board
[11:25]  <snorp> since this stuff is going there too
[11:25]  <snorp> yeah I guess might as well be everywhere
[11:25]  <blassey> we'll be needing this on m-b in a few days
[11:25]  <bear> k
[11:25]  <blassey> and release 6 weeks after that
[11:25]  <blassey> it only needs to be android native though

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 593112 [details] [diff] [review]
change android mozconfig to reference sdk 14

Do you really want to be changing the mozconfigs for mozilla-beta and mozilla-release, especially at this cycle of the train?

Most of these mozconfigs should be updated, but I think will be discarded for http://hg.mozilla.org/mozilla-central/file/bbc7014db2de/mobile/android/config/mozconfigs/android and http://hg.mozilla.org/mozilla-central/file/bbc7014db2de/mobile/xul/config/mozconfigs/android .

The l10n-mozconfigs and the release mozconfigs probably need updating too.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Aki Sasaki [:aki] from comment #2)
> Comment on attachment 593112 [details] [diff] [review]
> change android mozconfig to reference sdk 14
> 
> Do you really want to be changing the mozconfigs for mozilla-beta and
> mozilla-release, especially at this cycle of the train?
Yes, the patch that requires this SDK bump will be making its way to aurora and beta this week baring any unexpected issues on trunk. 

If it makes more sense to change trunk now and aurora and beta tomorrow, that's fine. But my assumption is that is just more work for little gain.

Comment 4

[Aki Sasaki (not active)]

(In reply to Brad Lassey [:blassey] from comment #3)
> (In reply to Aki Sasaki [:aki] from comment #2)
> > Comment on attachment 593112 [details] [diff] [review]
> > change android mozconfig to reference sdk 14
> > 
> > Do you really want to be changing the mozconfigs for mozilla-beta and
> > mozilla-release, especially at this cycle of the train?
> Yes, the patch that requires this SDK bump will be making its way to aurora
> and beta this week baring any unexpected issues on trunk. 
> 
> If it makes more sense to change trunk now and aurora and beta tomorrow,
> that's fine. But my assumption is that is just more work for little gain.

That doesn't cover mozilla-release.
Also, for mozilla-central and mozilla-aurora at least, opt android and android-xul builds should be using the in-tree mozconfigs.

Comment 5

[Mike Taylor [:bear]]

Attachment: removed m-r change and also did all required for android-debug

Comment 6

[Mike Taylor [:bear]]

Comment on attachment 593192 [details] [diff] [review]
removed m-r change and also did all required for android-debug

committed changeset 5390:1ea1bdc7f6f7

Comment 7

[Mike Taylor [:bear]]

merged to production