Closed Bug 722727 Opened 12 years ago Closed 11 years ago

GCLI should make the value available to max/min functions

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P4)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 22

People

(Reporter: jwalker, Assigned: jwalker)

Details

Attachments

(1 file)

v1
47.70 KB, patch
miker
: review+
Details | Diff | Splinter Review 
      No description provided.
It's reasonable for max/min functions to know about other parameters.
We could just pass the requisition into max/min however that could trip us up later. It would be better to pass in a more limited set of data - something more like ExecutionContext.
Priority: -- → P4
(In reply to Joe Walker from comment #1)
> It's reasonable for max/min functions to know about other parameters.
> We could just pass the requisition into max/min however that could trip us
> up later. It would be better to pass in a more limited set of data -
> something more like ExecutionContext.

We could also just pass in (args) - probably good enough for most cases.
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools: Console → Developer Tools: Graphic Commandline and Toolbar
Attached patch v1 — — Splinter Review 
Assignee: nobody → jwalker
Status: NEW → ASSIGNED

    
    

    
  
The oranges on try were due to a different patch. Can be safely ignored.

    
    

    
  
Comment on attachment 728130 [details] [diff] [review]
v1

Also available on github, where the changes are explained step by step.
https://github.com/joewalker/gcli/pull/8

(I realized that I could pull-request myself, so no need to be able to push changes to your repo, and I can keep future pull-requests together)

        Attachment #728130 -
        Flags: review?(mratcliffe)

        Attachment #728130 -
        Flags: review?(mratcliffe) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4ff44d1d4750
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22

    
  
Product: Firefox → DevTools

    
  
Product: DevTools → DevTools Graveyard

          You need to log in
          before you can comment on or make changes to this bug.