722727 - GCLI should make the value available to max/min functions

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P4)

Comment 1

[Joe Walker [:jwalker]]

It's reasonable for max/min functions to know about other parameters.
We could just pass the requisition into max/min however that could trip us up later. It would be better to pass in a more limited set of data - something more like ExecutionContext.

Comment 2

[Joe Walker [:jwalker]]

(In reply to Joe Walker from comment #1)
> It's reasonable for max/min functions to know about other parameters.
> We could just pass the requisition into max/min however that could trip us
> up later. It would be better to pass in a more limited set of data -
> something more like ExecutionContext.

We could also just pass in (args) - probably good enough for most cases.

Comment 3

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 4

[Joe Walker [:jwalker]]

Attachment: v1

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=eb3301ae6387

Comment 6

[Joe Walker [:jwalker]]

The oranges on try were due to a different patch. Can be safely ignored.

Comment 7

[Joe Walker [:jwalker]]

Comment on attachment 728130 [details] [diff] [review]
v1

Also available on github, where the changes are explained step by step.
https://github.com/joewalker/gcli/pull/8

(I realized that I could pull-request myself, so no need to be able to push changes to your repo, and I can keep future pull-requests together)

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=d5cdec6efff9
https://hg.mozilla.org/integration/fx-team/rev/4ff44d1d4750

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/4ff44d1d4750