Closed Bug 722730 Opened 14 years ago Closed 14 years ago

Read after free to do with URL classifier

Categories

(Toolkit :: Safe Browsing, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: jseward, Unassigned)

Details

(Keywords: valgrind)

m-c as of about 6 hours ago, at shutdown; i see a read after free report as shown below. Unfortunately does not repeat reliably -- maybe a threading issue? Considering that nsXPCWrappedJS::Release() appears in both stacks, I'd guess its some kind of refcounting snafu. But maybe induced by a shutdown race? Just guessing. Invalid read of size 4 at 0x882ADCA: nsXPCWrappedJS::Release() (nsISupportsImpl.h:278) by 0x8984EA9: UrlClassifierCallbackProxy::Release() (nsCOMPtr.h:476) by 0x8985E66: UrlClassifierDBServiceWorkerProxy::GetTablesRunnable::~GetTablesRunnable() (nsCOMPtr.h:476) by 0x8CAE7DC: nsRunnable::Release() (nsThreadUtils.cpp:55) by 0x8CE9115: nsThread::ProcessNextEvent(bool, bool*) (nsCOMPtr.h:476) by 0x8CAE939: NS_ProcessNextEvent_P(nsIThread*, bool) (nsThreadUtils.cpp:245) by 0x8CE8E74: nsThread::ThreadFunc(void*) (nsThread.cpp:289) by 0x61A10B2: _pt_root (ptthread.c:187) by 0x4E35970: start_thread (pthread_create.c:304) by 0x5AD192C: clone (clone.S:112) Address 0x1bfeee80 is 64 bytes inside a block of size 120 free'd at 0x4C27564: free (vg_replace_malloc.c:427) by 0x882AE78: nsXPCWrappedJS::Release() (XPCWrappedJS.cpp:232) by 0x8CB01CD: nsProxyReleaseEvent::Run() (nsProxyRelease.cpp:52) by 0x8CE910D: nsThread::ProcessNextEvent(bool, bool*) (nsThread.cpp:657) by 0x8CAE939: NS_ProcessNextEvent_P(nsIThread*, bool) (nsThreadUtils.cpp:245) by 0x8CE9C2E: nsThread::Shutdown() (nsThread.cpp:499) by 0x8977563: nsUrlClassifierDBService::Shutdown() (nsUrlClassifierDBService.cpp:4600) by 0x897947F: nsUrlClassifierDBService::Observe(nsISupports*, char const*, unsigned short const*) (nsUrlClassifierDBService.cpp:4555) by 0x8CC2359: nsObserverList::NotifyObservers(nsISupports*, char const*, unsigned short const*) (nsObserverList.cpp:130) by 0x8CC25D1: nsObserverService::NotifyObservers(nsISupports*, char const*, unsigned short const*) (nsObserverService.cpp:182) by 0x7F03C06: nsXREDirProvider::DoShutdown() (nsXREDirProvider.cpp:814) by 0x7EFD5B3: ScopedXPCOMStartup::~ScopedXPCOMStartup() (nsAppRunner.cpp:1108)
Keywords: valgrind
Dave, can you file this in the right spot and cc anyone who should look at it?
STR -- my best guess: start Fx on valgrind, load http://www.google.co.uk (not sure if that's necessary, but anyway), and just let fx idle for about two minutes -- not much longer.
Product: Firefox → Toolkit
QA Contact: general → general
Component: General → Phishing Protection
Product: Toolkit → Firefox
QA Contact: general → phishing.protection
I can no longer reproduce this. I'm going to close it as invalid.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.