722842 - Spell Check checkmark is in opposite state

Status: ASSIGNED

(SeaMonkey :: Composer, defect)

Description

[Ned Phipps]

When spell-checking is active the menu item is unchecked.
When inactive, the menu item is checked.

Comment 1

[therube]

Heh. Confirmed.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a2) Gecko/20120131 Firefox/11.0a2 SeaMonkey/2.8a2

Comment 2

[therube]

DUP: Bug 296299 - 'Options > Spellcheck As You Type' mark looks active, while its entry is disabled

Comment 3

[Philip Chee]

therube: Ancient bugs are unlikely to be the same cause.
CC the usual suspects.

Comment 4

[Ian Neal]

As far as I can tell the logic has not changed, but that logic does assume spell checking as you type is off as default. Has something changed to make it on as default?

Comment 5

[Ian Neal]

Attachment: Correct checkbox status

This patch:
* makes sure the checkbox reflects InlineSpellCheckerUI.enabled

I did dig around but I could not see what has landed that made it behave differently.

Comment 6

[[e-mail]]

(In reply to Ian Neal from comment #5)
> I did dig around but I could not see what has landed that made it behave
> differently.
I dug around a bit harder and it's bug 434998 which makes the document think that design mode is on and therefore spellchecking should be on by default.

We didn't want to turn spellchecking on by default before because it would proceed to spellcheck the entire document which could take some time. Ehsan?

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to [e-mail] from comment #6)

> We didn't want to turn spellchecking on by default before because it would
> proceed to spellcheck the entire document which could take some time. Ehsan?

Spellchecking on by default raises a big issue: switching back from source
to wysiwyg view triggers a spellcheck of the whole document, possibly taking
too much time seen from a user's perspective. That's why Nvu had an dismissible
alert ("don't show this alert again") warning the user to disable spellcheck
through preferences if switch back to normal view was too slow.

Comment 8

[(no longer active)]

The editor turns on spell checking as it's being initialized as the default behavior.  It just happened that bug 434998 fixed a bug which SeaMonkey was relying on.  But turning spell checking off for xul:editor is totally supported, and if Composer wants that behavior, it should turn it off explicitly.

Comment 9

[(no longer active)]

This is how you should do it: http://mxr.mozilla.org/mozilla-central/source/editor/idl/nsIEditor.idl#303

Comment 10

[[e-mail]]

Comment on attachment 593643 [details] [diff] [review]
Correct checkbox status

Well, I think I would prefer to stick with disabling spellcheck by default, although we should do it with InlineSpellCheckerUI rather than mucking around with editor directly.

Comment 11

[Phoenix]

Assignment still valid?

Comment 12

[Philip Chee]

(In reply to Phoenix from comment #11)
> Assignment still valid?
Ping IanN and NeilAway