IonMonkey: TI is not enabled for ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 593255 [details] [diff] [review]
/home/mrosenberg/patches/turnOnTI-r0.patch

Looks like there was a typo in the old MacroAssembler that caused TI to never get turned on in my tests (or almost any other ARM tests).
Attachment #593255 - Flags: review?(dvander)
(Reporter)

Comment 1

6 years ago
Created attachment 593266 [details] [diff] [review]
change the location of a check to a more sane location

dvander pointed out that (this == NULL) isn't valid C++, so I've pulled the check out to the calling functions.
Attachment #593255 - Attachment is obsolete: true
Attachment #593255 - Flags: review?(dvander)
(Reporter)

Updated

6 years ago
Attachment #593266 - Flags: review?(dvander)
Attachment #593266 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/d283b00c1f73
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.