722961 - Make some tests for autocomplete with IME

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Like other IME tests, we should test the autocomplete behavior when user is using IME. Then, we can remove the tests for autocomplete of bug 717147.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, toolkit/content/tests/chrome/test_autocomplete_with_composition.xul might be better path.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

This tests both nsIAutoCompleteInput implementation, XUL <textbox type="autocomplete"> and nsFormFillController. Actual testing is in file_autocomplete_with_composition.js. test_autocomplete_with_composition_on_textbox.xul and test_autocomplete_with_composition_on_input.html use it.

This tests can be passed with the patch in bug 720659.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The new tests can be passed without the fix of bug 720659.

I should add more tests but anyway the tests are useful for other cases.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 593789 [details] [diff] [review]
Patch

I'm going to attach new patch which has more tests.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

gavin: ping

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Is there anyone more familiar with IME available to review this? I'm not sure that I can usefully review it.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #7)
> Is there anyone more familiar with IME available to review this? I'm not
> sure that I can usefully review it.

For the IME behavior, Kato-san may be one of good reviewers. However, I'm not sure he is familiar with autocomplete.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 603228 [details] [diff] [review]
Patch

I think he is likely to be a better reviewer than I am.

Kato-san, if you cannot review this you can re-direct it back to me.

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 603228 [details] [diff] [review]
Patch

Review of attachment 603228 [details] [diff] [review]:
-----------------------------------------------------------------

good

::: toolkit/content/tests/chrome/test_autocomplete_with_composition_on_input.html
@@ +4,5 @@
> +  <title>autocomplete with composition tests on HTML input element</title>
> +  <script type="text/javascript" src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>
> +  <script type="text/javascript" src="chrome://mochikit/content/tests/SimpleTest/EventUtils.js"></script>
> +  <script type="text/javascript" src="chrome://mochikit/content/tests/SimpleTest/ChromeUtils.js"></script>
> +  <script type="text/javascript" src="chrome://mochikit/content/tests/SimpleTest/ChromeUtils.js"></script>

twice ChromeUtils.js?

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4aaab8a2af6

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e4aaab8a2af6