Last Comment Bug 722965 - Remove MOZ_TOUCH ifdefs
: Remove MOZ_TOUCH ifdefs
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Wesley Johnston (:wesj)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-31 19:54 PST by Wesley Johnston (:wesj)
Modified: 2012-03-20 03:52 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (15.38 KB, patch)
2012-03-01 15:26 PST, Wesley Johnston (:wesj)
bugs: review+
Details | Diff | Splinter Review

Description Wesley Johnston (:wesj) 2012-01-31 19:54:42 PST
We put these in so we could move touch events forward on mobile with minimum changes to desktop. We should remove them now (assuming the tests pass...)
Comment 1 Wesley Johnston (:wesj) 2012-03-01 15:26:04 PST
Created attachment 602153 [details] [diff] [review]
Patch

Lets see how this fares on try:
https://tbpl.mozilla.org/?tree=Try&rev=0aeeb6abc514
Comment 2 Mozilla RelEng Bot 2012-03-01 19:31:08 PST
Try run for 0aeeb6abc514 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0aeeb6abc514
Results (out of 219 total builds):
    success: 178
    warnings: 39
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wjohnston@mozilla.com-0aeeb6abc514
Comment 3 Wesley Johnston (:wesj) 2012-03-01 19:51:58 PST
Comment on attachment 602153 [details] [diff] [review]
Patch

Looks good in tests! I didn't pull the MOZ_TOUCH stuff from gonk.
Comment 4 Timothy Nikkel (:tnikkel) 2012-03-03 13:26:26 PST
I landed bug 664707 which touches both GetEventCoordinatesRelativeTo in the same way, so when you land you'll have to account for that.
Comment 6 Mounir Lamouri (:mounir) 2012-03-20 03:52:40 PDT
https://hg.mozilla.org/mozilla-central/rev/b7d5d46662bc

Note You need to log in before you can comment on or make changes to this bug.