IonMonkey: Don't coerce comparison operands

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 593370 [details] [diff] [review]
Patch

Fixes v8-crypto. The problem was that "x == null" would return true instead of false if x is 0. Now we specialize as int32 if both operands are int32, and specialize as double if both operands are either int32 or double.
Attachment #593370 - Flags: review?(dvander)
(Assignee)

Comment 2

5 years ago
Created attachment 593389 [details] [diff] [review]
Patch
Attachment #593370 - Attachment is obsolete: true
Attachment #593370 - Flags: review?(dvander)
Attachment #593389 - Flags: review?(dvander)
Attachment #593389 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/06387601d4db
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.