723103 - Properly update about:home when history is cleared

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Lucas Rocha (:lucasr)]

Right now we show an empty space on the top sites section. It should show the message stating that there are no entries in history.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Update about:home's top sites section after history is cleared

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 593438 [details] [diff] [review]
Update about:home's top sites section after history is cleared

Oh boy. This is getting even more tightly coupled. I really want to look into ways of de-coupling this kind of code. We should not need direct access to AboutHome in this file, IMO.

File a new bug for finding ways to decouple?

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 593438 [details] [diff] [review]
> Update about:home's top sites section after history is cleared
> 
> Oh boy. This is getting even more tightly coupled. I really want to look
> into ways of de-coupling this kind of code. We should not need direct access
> to AboutHome in this file, IMO.
> 
> File a new bug for finding ways to decouple?

Let me first dig this a bit more and try to come up with an event-based approach. I agree the coupling is not ideal. Same applies to the patch in bug 719434.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Update about:home's top sites section after history is cleared

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 595016 [details] [diff] [review]
Update about:home's top sites section after history is cleared

>diff --git a/mobile/android/base/ConfirmPreference.java b/mobile/android/base/ConfirmPreference.java

>+import java.util.EnumSet;

You might need to move this to GeckoApp.java

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/36a22ca6439d

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 595016 [details] [diff] [review]
Update about:home's top sites section after history is cleared

[Beta/Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Inconsistent state on about:home
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: None

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/36a22ca6439d

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 595016 [details] [diff] [review]
Update about:home's top sites section after history is cleared

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 10

[Camelia Urian]

Nightly 13.0a1 (2012-02-21)
Device: Samsung Nexus S - Android 2.3.6

Verified fixed on Nightly.

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 595016 [details] [diff] [review]
Update about:home's top sites section after history is cleared

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 12

[Camelia Urian]

Nightly 13.0a1 (2012-02-28)
Device: Samsung Nexus S - Android 2.3.6

Verified fixed