723111 - Make it easier to completely unwrap an object

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch

js::UnwrapObject currently has the following behavior:

If you pass an outer window directly to it, it returns the inner window ("unwrapping" the outer).

If you pass a security wrapper to it, it will unwrap up to the outer window, but won't unwrap it. This is useful for the case where we want to peak under the security wrappers, but don't actually need the native out of the JS object.

It turns out that it'd be useful to have an API that lets us get the innermost object. This patch adds that API and uses it in the two existing places that it seems to be useful.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 593445 [details] [diff] [review]
patch

r=me

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 593445 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/9aac714775b9

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 593445 [details] [diff] [review]
patch

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d7c7ea755e54 - about 90 short of passing make check.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Updated patch

Carrying forward review: I missed a use of UnwrapObject in js/src/shell/js.cpp. Everything else is the same and the fix is trivial.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 593555 [details] [diff] [review]
Updated patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cbc1a15094e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1cbc1a15094e